<html><body>
<pre>[ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]</pre>
<h3>Barak Korren updated OVIRT-1895:</h3>
<pre>Component/s: Gerrit/git
Epic Link: OVIRT-400
Issue Type: Bug (was: By-EMAIL)</pre>
<blockquote><h3>CI votes not forwarded on commit message change</h3>
<pre> Key: OVIRT-1895
URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
Project: oVirt - virtualization made easy
Issue Type: Bug
Components: Gerrit/git
Reporter: Yedidyah Bar David
Assignee: infra</pre>
<p>Hi all, If a change goes through this flow:</p>
<ol><li><p>Push an update N</p></li>
<li><p>CI triggers check-patch for N</p></li>
<li><p>Push another update N+1 that changes only commit message</p></li>
<li><p>CI marks +1 N</p></li></ol>
<p>Then we have logic to not trigger CI for N+1 (with the assumption that a change to commit message should not affect the result), but also do not mark +1 N+1, leaving the patch unmarked. We should either forward the +1, when giving it, to all consecutive future patchsets that only changed the commit message, or give up on the optimization and always trigger CI. As an example, see: <a href="https://gerrit.ovirt.org/87515">https://gerrit.ovirt.org/87515</a> Best regards, — Didi</p></blockquote>
<p>— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100079)</p>
<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=i5TMWGV99amJbNxJpSp2-2BJ33BSM3tuiUfRTk64K-2BOjGpF-2BuMzoJRRB1ifzZIErtIxTccLy521zz7OxZViB5mnpbbwYJFz6flgevXOzUJVH-2FqBqvcqqqKIp3p4OcyDFOsRwvaLk1r7X8JpLEbbYtQ-2F8se-2FAoG3NqMy6MEF960fM4WCfArIPipDAxV3I9QtDxwIZkeNWD9yApPsdJra3V4NT7hIOoTif46hN9A2Na-2BIseHngSSOzrSPo87Xs5dlTOpnR2eyUM3U0bQGjqX7dapG-2FXqjV0biewMc9B5vgYee14bZTd0VSm0ddzt4OAFB1Veur8uw2k5Z8AtHDLQ8r8fBDFaWl958j82Uac9Kw7-2FaxCXk4YRoX0zy-2BuIhtIeFqW4fmUIMVrISfTZ5gJTcFeCdNt9v4k8qj-2B1iKI4lcu0FTRJhDPK7KjpUjhE6NfxKhMB" alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body></html>