<div dir="ltr"><div>The patch was reported to cause 3 different issues but I cannot say for sure that the notifier error was actually one of them. <br></div><div>I can say that all issues from master and 4.2 were cleared once the fix from Shmuel was merged and tested in cq. <br></div><div></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Mar 21, 2018 at 10:28 AM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><br><div><span class=""><br><blockquote type="cite"><div>On 20 Mar 2018, at 10:33, Yaniv Kaul <<a href="mailto:ykaul@redhat.com" target="_blank">ykaul@redhat.com</a>> wrote:</div><br class="m_-2134887805528739342Apple-interchange-newline"><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Mar 20, 2018 at 9:49 AM, Michal Skrivanek <span dir="ltr"><<a href="mailto:michal.skrivanek@redhat.com" target="_blank">michal.skrivanek@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">I’m not sure what is that test actually testing, if it depends on the previous host action which fails but is not verified it still may be relevant to Shmuel’s patch<br>adding author of the test and the notifier owner</div></blockquote><div><br></div><div>It is checking that the notifier works - which sends SNMP notifications on our events. I happen to picked an event which is VDC_STOP - which happens when the engine is restarted - which happens earlier, when we configure it.</div></div></div></div></div></blockquote><div><br></div></span>not sure if that’s reliable then. Doesn’t look related to that patch at all. Dafna, does the same error reproduce all the time after that exact patch?</div><div><div class="h5"><div><br><blockquote type="cite"><div><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Y.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space"><div><div><br><blockquote type="cite"><div><div class="m_-2134887805528739342h5"><div>On 19 Mar 2018, at 13:06, Dafna Ron <<a href="mailto:dron@redhat.com" target="_blank">dron@redhat.com</a>> wrote:</div><br class="m_-2134887805528739342m_-7487643208740782214Apple-interchange-newline"></div></div><div><div><div class="m_-2134887805528739342h5"><div dir="ltr"><div><div>Hi, <br><br></div>We had a failure in test 002_bootstrap.verify_notifier.<br></div><div>I can't see anything wrong with the notifier and I don't think it should be related to the change that was reported. <br><br></div><div>the test itself is looking for vdc_stop in messages which I do not indeed see but I am not sure what is the cause and how the reported change related to the failure. <br><br></div><div>Can you please take a look? <br><br><br><br></div><div><b style="font-weight:normal" id="m_-2134887805528739342m_-7487643208740782214gmail-docs-internal-guid-e8ba4241-3e25-14f2-4425-ad6f357e2e4a"><div style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-east-asian:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link and headline of suspected patches: </span></div></b><b style="font-weight:normal" id="m_-2134887805528739342m_-7487643208740782214gmail-docs-internal-guid-e8ba4241-3e25-14f2-4425-ad6f357e2e4a">core: USB in osinfo configuration depends on chipset - <a href="https://gerrit.ovirt.org/#/c/88777/" target="_blank">https://gerrit.ovirt.org/#/c/8<wbr>8777/</a><br><br><div style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-east-asian:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link to Job:</span></div><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6429/" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/6429/</a><br><br><div style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-east-asian:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">Link to all logs:</span></div><a href="http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/6429/artifacts" target="_blank">http://jenkins.ovirt.org/job/o<wbr>virt-master_change-queue-teste<wbr>r/6429/artifacts</a><br><br><div style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-east-asian:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap">(Relevant) error snippet from the log: </span></div><div style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-east-asian:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"><error></span></div><br></b></div><div><b style="font-weight:normal" id="m_-2134887805528739342m_-7487643208740782214gmail-docs-internal-guid-e8ba4241-3e25-14f2-4425-ad6f357e2e4a">this is the error from </b><span style="font-weight:normal">the api: <br><br></span><br><h3>Error Message</h3><pre>Failed grep for VDC_STOP with code 1. Output:
-------------------- >> begin captured logging << --------------------
lago.ssh: DEBUG: start task:f1231b27-f796-406c-8618-1<wbr>7b0868725bc:Get ssh client for lago-basic-suite-master-engine<wbr>:
lago.ssh: DEBUG: end task:f1231b27-f796-406c-8618-1<wbr>7b0868725bc:Get ssh client for lago-basic-suite-master-engine<wbr>:
lago.ssh: DEBUG: Running 1cce7c0c on lago-basic-suite-master-engine<wbr>: grep VDC_STOP /var/log/messages
lago.ssh: DEBUG: Command 1cce7c0c on lago-basic-suite-master-engine returned with 1
--------------------- >> end captured logging << ---------------------</pre><h3>Stacktrace</h3><pre> File "/usr/lib64/python2.7/unittest<wbr>/case.py", line 369, in run
testMethod()
File "/usr/lib/python2.7/site-packa<wbr>ges/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/testlib.py", line 129, in wrapped_test
test()
File "/usr/lib/python2.7/site-packa<wbr>ges/ovirtlago/testlib.py", line 59, in wrapper
return func(get_test_prefix(), *args, **kwargs)
File "/home/jenkins/workspace/ovirt<wbr>-master_change-queue-tester/<wbr>ovirt-system-tests/basic-<wbr>suite-master/test-scenarios/<wbr>002_bootstrap.py", line 1456, in verify_notifier
'Failed grep for VDC_STOP with code {0}. Output: {1}'.format(result.code, result.out)
File "/usr/lib/python2.7/site-packa<wbr>ges/nose/tools/trivial.py", line 29, in eq_
raise AssertionError(msg or "%r != %r" % (a, b))
'Failed grep for VDC_STOP with code 1. Output: \n-------------------- >> begin captured logging << --------------------\nlago.ssh<wbr>: DEBUG: start task:f1231b27-f796-406c-8618-1<wbr>7b0868725bc:Get ssh client for lago-basic-suite-master-engine<wbr>:\nlago.ssh: DEBUG: end task:f1231b27-f796-406c-8618-1<wbr>7b0868725bc:Get ssh client for lago-basic-suite-master-engine<wbr>:\nlago.ssh: DEBUG: Running 1cce7c0c on lago-basic-suite-master-engine<wbr>: grep VDC_STOP /var/log/messages\nlago.ssh: DEBUG: Command 1cce7c0c on lago-basic-suite-master-engine returned with 1\n--------------------- >> end captured logging << ---------------------'</pre><span style="font-weight:normal"></span></div><div><b style="font-weight:normal" id="m_-2134887805528739342m_-7487643208740782214gmail-docs-internal-guid-e8ba4241-3e25-14f2-4425-ad6f357e2e4a"><br><div style="line-height:1.38;margin-top:0pt;margin-bottom:0pt"><span style="font-size:11pt;font-family:Arial;background-color:transparent;font-weight:400;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-variant-east-asian:normal;text-decoration:none;vertical-align:baseline;white-space:pre-wrap"></error></span></div></b><br class="m_-2134887805528739342m_-7487643208740782214gmail-Apple-interchange-newline"></div></div></div></div>
______________________________<wbr>_________________<br>Devel mailing list<br><a href="mailto:Devel@ovirt.org" target="_blank">Devel@ovirt.org</a><br><a href="http://lists.ovirt.org/mailman/listinfo/devel" target="_blank">http://lists.ovirt.org/mailman<wbr>/listinfo/devel</a></div></blockquote></div><br></div></div></blockquote></div><br></div></div>
</div></blockquote></div><br></div></div></div></blockquote></div><br></div>