[Kimchi-devel] [project-kimchi] [PATCH] [Issue #287] Confirm box will be hidden by the window dialog

Hongliang Wang hlwang at linux.vnet.ibm.com
Wed Dec 18 05:22:25 UTC 2013


On 12/18/2013 11:20 AM, Xin Ding wrote:
> Signed-off-by: Xin Ding <xinding at linux.vnet.ibm.com>
Reviewed-by: Hongliang Wang <hlwang at linux.vnet.ibm.com>

Passed use cases on Chrome:

1. Create Guest
1.1. Remove all templates
1.2. Open Guest Tab
1.3. Click Add Button (+)
1.4. Click Add Template Button
1.5. Select local iso
1.6. Click Search more iso Button
1.7. Confirm box is right there on top of all windows

2. Consider Situation when User not Logged in
2.1. Open Host Tab
2.2. Click Shutdown Button and see a confirm box pop up
2.3. Log out by entering kimchi.logout(); in developer's tool console
2.4. Log-in window is right there on top of the confirm box
> ---
>   ui/js/src/kimchi.window.js | 12 ------------
>   1 file changed, 12 deletions(-)
>
> diff --git a/ui/js/src/kimchi.window.js b/ui/js/src/kimchi.window.js
> index 2212b5b..5cf8054 100644
> --- a/ui/js/src/kimchi.window.js
> +++ b/ui/js/src/kimchi.window.js
> @@ -26,18 +26,6 @@ kimchi.window = (function() {
>               url: settings
>           };
>
> -        if (_windows.length) {
> -            var lastZIndex = parseInt($('#' + _windows[_windows.length - 1]).css('zIndex'));
> -            if (settings['style']) {
> -                settings['style']['zIndex'] = lastZIndex + 1;
> -            }
> -            else {
> -                settings['style'] = {
> -                    zIndex: lastZIndex + 1
> -                };
> -            }
> -        }
> -
>           var windowID = settings['id'] || 'window-' + _windows.length;
>
>           if ($('#' + windowID).length) {

-- 
project-kimchi mailing list <project-kimchi at googlegroups.com>
https://groups.google.com/forum/#!forum/project-kimchi
--- 
You received this message because you are subscribed to the Google Groups "project-kimchi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to project-kimchi+unsubscribe at googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.



More information about the Kimchi-devel mailing list