[Kimchi-devel] [PATCH V4 0/5] Add spice backend support for kimchi

apporc appleorchard2000 at gmail.com
Wed Dec 25 14:51:57 UTC 2013


v4-v3:  
    1.  Remove not used module "copy" in vmtemplate.py(Thanks Aline)
    2.  Fix alignment problem in model.py(Thanks Aline)
    3.  Use type property of jsonschema to validate both ipv4 and ipv6(Thanks Aline)
        REF: http://stackoverflow.com/questions/14550235/json-schema-away-to-specify-an-any-type-schema-with-certain-required-fields
    4.  Use "$ref" to simply API.json, remove dumplicate content(Thanks Rodrigo)

v3-v2:
    1.  Rebase  to upstream
    2.  Improve/simplify some code according to reviewers' advice(Thanks Royce, Markwu and Aline).
    3.  Reimplement parameters validation using jsonschema.
    4.  Remove unnecessary test code in model.py.
    5.  Split patch to several smaller commits according to logic(Thanks Royce).

v2-v1:  Rebased to upstream and resend

v1: Add spice backend support for kimchi

apporc (5):
  Add spice backend support for kimchi
  Update mockmodel for spice support
  Validate graphics parameters input by users
  Update test case for graphics support
  Add graphics parameters description in API.md

 docs/API.md              | 43 ++++++++++++++++++++++-
 src/kimchi/API.json      | 30 +++++++++++++++--
 src/kimchi/controller.py | 14 +++++---
 src/kimchi/mockmodel.py  | 49 ++++++++++++++++++---------
 src/kimchi/model.py      | 43 +++++++++++++----------
 src/kimchi/osinfo.py     |  5 +--
 src/kimchi/vmtemplate.py | 31 +++++++++++++++--
 tests/test_mockmodel.py  |  2 ++
 tests/test_model.py      | 27 ++++++++++++++-
 tests/test_rest.py       | 88 +++++++++++++++++++++++++++++++++++++++++++++---
 tests/test_vmtemplate.py | 42 ++++++++++++++++++++---
 11 files changed, 319 insertions(+), 55 deletions(-)

-- 
1.8.1.2




More information about the Kimchi-devel mailing list