[Kimchi-devel] [PATCH v3 0/5] Support Creating iSCSI storage pool

Zhou Zheng Sheng zhshzhou at linux.vnet.ibm.com
Fri Dec 27 10:20:04 UTC 2013


This patch series is about creating iSCSI storage pool.
After this patch, you can create an ISCSI storage pool as the following.

Thanks the reviewers. I took most of your advices in v3 series.

curl -u root -H 'Content-type: application/json' \
      -H 'Accept: application/json' \
      -d '{"source": {
              "target": "iqn.2013-01.example.com.targetname",
              "host": "192.168.X.X",
              "port": 326X,
              "auth": {"username": "testUser", "password": "123456"}},
           "type": "iscsi",
           "name": "testIscsiPool"}' \
      http://127.0.0.1:8000/storagepools

Note the "port" and "auth" is optional.

Zhou Zheng Sheng (5):
  storagepool: refactor _get_pool_xml()
	This patch is to refactor current storage pool XML generation code
	to be more extensible.
	v2 -> v3: Extract a StoragePoolDef class and define "prepare()" and
	"create()" method.

  storagepool: rename and consolidate arguments of creating (back end)
	This patch is to consolidate argument serving the same purpose
	under the same name.
	v2 -> v3: Fix typo.

  storagepool: rename and consolidate arguments of creating (front end)
	This patch is the respective front-end changes for the above patch.
	v2 -> v3: No change.

  storagepool: Support Creating iSCSI storagepool in model.py
    This patch is to validate iSCSI host and auth, and create libvirt
	iSCSI storage pool.
	v2 -> v3: Support iSCSI CHAP auth. Add more test cases.

  test_model: test creating iSCSI storage pool
    v2 -> v3: Do not create directory for storage pool, pool.build()
	create it automatically.

 Makefile.am                              |   2 +
 docs/API.md                              |  28 ++--
 src/kimchi/Makefile.am                   |   1 +
 src/kimchi/iscsi.py                      |  89 ++++++++++++
 src/kimchi/model.py                      | 223 +++++++++++++++++++++++++------
 tests/Makefile.am                        |   1 +
 tests/test_model.py                      |  89 ++++++------
 tests/test_storagepool.py                | 156 +++++++++++++++++++++
 ui/js/src/kimchi.storagepool_add_main.js |  13 +-
 9 files changed, 513 insertions(+), 89 deletions(-)
 create mode 100644 src/kimchi/iscsi.py
 create mode 100644 tests/test_storagepool.py

-- 
1.7.11.7




More information about the Kimchi-devel mailing list