[Kimchi-devel] [PATCH 1/6] isoinfo: Add ignore_list paramter to main program

[Royce Lv]

On 2013年12月31日 01:09, Aline Manera wrote:
> From: Aline Manera <alinefm at br.ibm.com>
>
> ignore_list parameter was added to avoid displaying duplicated results during
> deep scan.
> So isoinfo main program must be updated accordingly or it will raise the
> following error:
>
> $ python kimchi/isoinfo.py http://localhost/Fedora-Live-Desktop-x86_64-19-1.iso
> Traceback (most recent call last):
>    File "kimchi/isoinfo.py", line 343, in <module>
>      probe_iso(None, dict(path=sys.argv[1], updater=updater))
>    File "kimchi/isoinfo.py", line 283, in probe_iso
>      ignore_list = params['ignore_list']
> KeyError: 'ignore_list'
>
> Signed-off-by: Aline Manera <alinefm at br.ibm.com>
> ---
>   src/kimchi/isoinfo.py |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/kimchi/isoinfo.py b/src/kimchi/isoinfo.py
> index f76fd90..8f4738c 100644
> --- a/src/kimchi/isoinfo.py
> +++ b/src/kimchi/isoinfo.py
> @@ -340,5 +340,5 @@ if __name__ == '__main__':
>       iso_list = []
>       def updater(iso_info):
>           iso_list.append(iso_info)
> -    probe_iso(None, dict(path=sys.argv[1], updater=updater))
> +    probe_iso(None, dict(path=sys.argv[1], updater=updater, ignore_list=[]))
>       print iso_list
Without affecting the upper layer,

What about change :

def probe_iso(status_helper, params):
loc = params['path'].encode("utf-8")
updater = params['updater']
ignore = False
ignore_list = params.get('ignore_list', [])