[Kimchi-devel] [PATCH V2 3/3] change the vm name in test case

[Aline Manera]

On 02/10/2014 01:32 PM, Sheldon wrote:
> On 02/10/2014 11:27 PM, Aline Manera wrote:
>> On 02/10/2014 05:48 AM, shaohef at linux.vnet.ibm.com wrote:
>>> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>>>
>>> change kīмkhī to kīмсhī
>>> kīмсhī looks like the acssii "kimchi"
>>>
>>> Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>>> ---
>>>   tests/test_model.py | 12 ++++++------
>>>   1 file changed, 6 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/tests/test_model.py b/tests/test_model.py
>>> index ef15be5..28480fa 100644
>>> --- a/tests/test_model.py
>>> +++ b/tests/test_model.py
>>> @@ -623,17 +623,17 @@ class ModelTests(unittest.TestCase):
>>>               inst.templates_create(params)
>>>               rollback.prependDefer(inst.template_delete, 'test')
>>>   -            params = {'name': u'kīмkhī-∨м', 'template': 
>>> u'/templates/test'}
>>> +            params = {'name': u'kīмсhī-∨м', 'template': 
>>> u'/templates/test'}
>>>               inst.vms_create(params)
>>> -            rollback.prependDefer(inst.vm_delete, u'kīмkhī-∨м')
>>> +            rollback.prependDefer(inst.vm_delete, u'kīмсhī-∨м')
>>>   -            inst.vm_start(u'kīмkhī-∨м')
>>> -            rollback.prependDefer(inst.vm_stop, u'kīмkhī-∨м')
>>> +            inst.vm_start(u'kīмсhī-∨м')
>>> +            rollback.prependDefer(inst.vm_stop, u'kīмсhī-∨м')
>>>   -            inst.vm_delete(u'kīмkhī-∨м')
>>> +            inst.vm_delete(u'kīмсhī-∨м')
>>>                 vms = inst.vms_get_list()
>>> -            self.assertFalse(u'kīмkhī-∨м' in vms)
>>> +            self.assertFalse(u'kīмсhī-∨м' in vms)
>>
>> Sorry, but I could not see any differences in the lines added and 
>> removed
> The difference is "k" -> "с"
>
> 'kīмkhī ' do not looks like "kimchi"
> 'kīмсhī ' looks like "kimchi"
>
> so sorry,
> actually 'kīмkhī ' is a typo in one of  my former commit.
> I want to use "kimchi" instead of 'kīмkhī '

Thanks for open my eyes! =)

>>
>>> @unittest.skipUnless(utils.running_as_root(), 'Must be run as root')
>>>       def test_vm_list_sorted(self):
>>
>>
>>
>
>