[Kimchi-devel] [PATCH] bug fix: Package doc html files into deb package

[Crístian Viana]

NACK

This patch does not generate the HTML files when I type "make". Instead, 
a file named "*.html" is generated with the HTML content one of the DITA 
files.

Am 18-02-2014 05:26, schrieb shaohef at linux.vnet.ibm.com:
> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
>
> To get the help html files dinamically the Makefile was using the
> following code:
>
> DITA_HTML_FILES = $(patsubst %.dita,%.html,$(wildcard *.dita))
> $(wildcard *.html)
>
> But it does not well while building deb packages as it cointans
> duplicated values:
>
>   /bin/mkdir -p '/tmp/tmp.86vGERYO70/usr/share/kimchi/ui/pages/help'
>   /usr/bin/install -c -m 644 guests.html storage.html templates.html
> guests.html index.html storage.html templates.html
> '/tmp/tmp.86vGERYO70/usr/share/kimchi/ui/pages/help'
> /usr/bin/install: will not overwrite just-created
> `/tmp/tmp.86vGERYO70/usr/share/kimchi/ui/pages/help/guests.html' with
> `guests.html'
> (...)
>
> Fix it.
> Add *.html to HTML_FILES directly.
>
> Also add *.dita and dita-help.xsl to the EXTRA_DIST list.
>
> Signed-off-by: Aline Manera <alinefm at br.ibm.com>
> Signed-off-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
> ---

> +EXTRA_DIST = \
> +        $(DITA_XSL_FILE) \
> +	$(DITA_FILES)    \
> +	$(NULL)
Why do we need to add the XSL and DITA files to the distribution 
packages? They won't be used at all.