[Kimchi-devel] [PATCH] Fix directory path validation for 'DIR' type storage pool

Sheldon shaohef at linux.vnet.ibm.com
Fri Feb 21 09:38:06 UTC 2014


Reviewed-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>

On 02/21/2014 05:15 PM, Mark Wu wrote:
> The current regex will refuse the strings which end with '/'.
> Obviously, even if the dir path ends with '/', it's still valid.
> So this patch changes the regex to accept this case.
>
> Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
> ---
>   ui/js/src/kimchi.storagepool_add_main.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js
> index ac97e1a..8c0025f 100644
> --- a/ui/js/src/kimchi.storagepool_add_main.js
> +++ b/ui/js/src/kimchi.storagepool_add_main.js
> @@ -167,7 +167,7 @@ kimchi.validateDirForm = function () {
>           kimchi.message.error.code('KCHPOOL6002E');
>           return false;
>       }
> -    if (!/((\/([0-9a-zA-Z-_\.]+)))$/.test(path)) {
> +    if (!/(\/([0-9a-zA-Z-_\.]+))+\/?$/.test(path)) {
>           kimchi.message.error.code('KCHAPI6003E');
>           return false;
>       }


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center




More information about the Kimchi-devel mailing list