[Kimchi-devel] [PATCH] Fix directory path validation for 'DIR' type storage pool

[Aline Manera]

On 02/21/2014 06:15 AM, Mark Wu wrote:
> The current regex will refuse the strings which end with '/'.
> Obviously, even if the dir path ends with '/', it's still valid.
> So this patch changes the regex to accept this case.
>
> Signed-off-by: Mark Wu <wudxw at linux.vnet.ibm.com>
> ---
>   ui/js/src/kimchi.storagepool_add_main.js | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js
> index ac97e1a..8c0025f 100644
> --- a/ui/js/src/kimchi.storagepool_add_main.js
> +++ b/ui/js/src/kimchi.storagepool_add_main.js
> @@ -167,7 +167,7 @@ kimchi.validateDirForm = function () {
>           kimchi.message.error.code('KCHPOOL6002E');
>           return false;
>       }
> -    if (!/((\/([0-9a-zA-Z-_\.]+)))$/.test(path)) {
> +    if (!/(\/([0-9a-zA-Z-_\.]+))+\/?$/.test(path)) {

This verification is restricting so much the user.
I can have any valid path in my system.

/aline manera/
/crístian /
/阿莲

This verification should be done in backend. For UI, we should only 
check if the string starts with /

>           kimchi.message.error.code('KCHAPI6003E');
>           return false;
>       }