[Kimchi-devel] [PATCH 0/5] Fix VM error messages handling

[Aline Manera]

The tests are failing with this patch set.
Seems it is because you remove the _vm_exists verification while 
deleting the vm

======================================================================
ERROR: test_delete_running_vm (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/alinefm/kimchi/tests/test_model.py", line 780, in 
test_delete_running_vm
self.assertFalse(u'kīмсhī-∨м' in vms)
File "/home/alinefm/kimchi/src/kimchi/rollbackcontext.py", line 58, in 
__exit__
undo(*args, **kwargs)
File "/home/alinefm/kimchi/src/kimchi/model/vms.py", line 380, in stop
dom = self.get_vm(name, self.conn)
File "/home/alinefm/kimchi/src/kimchi/model/vms.py", line 333, in get_vm
raise NotFoundError("KCHVM0002E", {'name': name})
NotFoundError: KCHVM0002E: KCHVM0002E

======================================================================
ERROR: test_vm_edit (test_model.ModelTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/alinefm/kimchi/tests/test_model.py", line 572, in test_vm_edit
rollback.prependDefer(inst.vm_delete, u'пeω-∨м')
File "/home/alinefm/kimchi/src/kimchi/rollbackcontext.py", line 58, in 
__exit__
undo(*args, **kwargs)
File "/home/alinefm/kimchi/src/kimchi/model/vms.py", line 380, in stop
dom = self.get_vm(name, self.conn)
File "/home/alinefm/kimchi/src/kimchi/model/vms.py", line 333, in get_vm
raise NotFoundError("KCHVM0002E", {'name': name})
NotFoundError: KCHVM0002E: KCHVM0002E

----------------------------------------------------------------------
Ran 157 tests in 130.604s

FAILED (errors=2)
[25/Feb/2014:10:21:53] ENGINE Waiting for child threads to terminate...
make[3]: *** [check-local] Error 1
make[3]: Leaving directory `/home/alinefm/kimchi/tests'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/home/alinefm/kimchi/tests'
make[1]: *** [check] Error 2
make[1]: Leaving directory `/home/alinefm/kimchi/tests'
make: *** [check-recursive] Error 1


On 02/24/2014 05:27 PM, Rodrigo Trujillo wrote:
> The Guest tab was not showing backend error messages properly. So user was
> not able to know what happened if a VM failed to start, stop, reset or delete.
> In order to fix this, both backend and frontend had to be changed.
>
> Rodrigo Trujillo (5):
>    Fix vm start UI error return message
>    Fix VM stop error messages handling (backend/UI)
>    Fix VM reset (UI) error messages hnadling
>    Fix VM delete error message handling (UI/Backend)
>    Delete unsed _vm_exists funtion
>
>   src/kimchi/i18n.py             |  2 ++
>   src/kimchi/model/vms.py        | 51 ++++++++++++++++++++----------------------
>   ui/js/src/kimchi.guest_main.js | 26 ++++++++++-----------
>   ui/pages/i18n.html.tmpl        |  1 +
>   4 files changed, 40 insertions(+), 40 deletions(-)
>