[Kimchi-devel] [PATCH] Packaging: removed start of kimchid from RPM and DEB files

Paulo Vital pvital at linux.vnet.ibm.com
Tue Feb 25 15:43:48 UTC 2014


It's not a good practice to start services automatically in the end of RPM
or DEB installation. So, this patch is removing any reference to start the
kimchid service automatically.

Tested on Fedora 19 and RHEL 6.5.

Signed-off-by: Paulo Vital <pvital at linux.vnet.ibm.com>
---
 contrib/DEBIAN/postinst       | 1 -
 contrib/kimchi.spec.fedora.in | 6 ------
 contrib/kimchi.spec.suse.in   | 1 -
 3 files changed, 8 deletions(-)

diff --git a/contrib/DEBIAN/postinst b/contrib/DEBIAN/postinst
index 5f7e2ff..5bca009 100755
--- a/contrib/DEBIAN/postinst
+++ b/contrib/DEBIAN/postinst
@@ -18,7 +18,6 @@
 # License along with this library; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
 
-service kimchid start
 set +e
 service firewalld status >/dev/null 2>&1
 if [ $? -ne 0 ]; then
diff --git a/contrib/kimchi.spec.fedora.in b/contrib/kimchi.spec.fedora.in
index 558bda2..149c3a7 100644
--- a/contrib/kimchi.spec.fedora.in
+++ b/contrib/kimchi.spec.fedora.in
@@ -88,12 +88,6 @@ if [ $1 -eq 1 ] ; then
     /bin/systemctl daemon-reload >/dev/null 2>&1 || :
 fi
 
-%if 0%{?rhel} == 6
-start kimchid
-%else
-service kimchid start
-%endif
-
 %if 0%{?with_systemd}
 service firewalld status >/dev/null 2>&1
 if [ $? -ne 0 ]; then
diff --git a/contrib/kimchi.spec.suse.in b/contrib/kimchi.spec.suse.in
index 97e66bc..99b4fea 100644
--- a/contrib/kimchi.spec.suse.in
+++ b/contrib/kimchi.spec.suse.in
@@ -49,7 +49,6 @@ install -Dm 0755 contrib/kimchid.sysvinit %{buildroot}%{_initrddir}/kimchid
 
 
 %post
-service kimchid start
 chkconfig kimchid on
 
 %preun
-- 
1.8.3.1




More information about the Kimchi-devel mailing list