[Kimchi-devel] [PATCH] Fix debug report creation in API.json

Rodrigo Trujillo rodrigo.trujillo at linux.vnet.ibm.com
Thu Feb 27 15:15:41 UTC 2014


Yeap, the report name was auto-generated only in UI before, then I moved 
to backend some days ago.
This way the name is not required anymore.

Thanks,

Rodrigo

On 02/27/2014 11:31 AM, Aline Manera wrote:
> On 02/27/2014 06:31 AM, lvroyce at linux.vnet.ibm.com wrote:
>> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>>
>> Because debug report creation name is mandatory,
>> add this field to require.
>
> This is not mandatory.
> When any name is passed by the user the backend automatically generate 
> one.
>
> Look at src/model/debugreports.py (line 42)
>
>         # Generate a name with time and millisec precision, if necessary
>         if ident is None or ident == "":
>             ident = 'report-' + str(int(time.time()*1000))
>
>
>>
>> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
>> ---
>>   src/kimchi/API.json | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/kimchi/API.json b/src/kimchi/API.json
>> index f595bbf..153162d 100644
>> --- a/src/kimchi/API.json
>> +++ b/src/kimchi/API.json
>> @@ -37,6 +37,7 @@
>>                       "description": "The name for the debug report 
>> file.",
>>                       "type": "string",
>>                       "pattern": "^[A-Za-z0-9-]*$",
>> +                    "required": true,
>>                       "error": "KCHDR0007E"
>>                   }
>>               }
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>




More information about the Kimchi-devel mailing list