[Kimchi-devel] [PATCH ] Fix screenshots and debug reports paths.

Shu Ming shuming at linux.vnet.ibm.com
Thu Feb 27 15:39:41 UTC 2014


2014/2/27 21:47, Paulo Ricardo Paz Vital:
> Ming,
>
> Your patch solves only the DebugReports problem, while Leonardo's patch
> solves any difference between what UI expects and backend sets.
I was planing to send screenshot patch later after all of us agree with 
the method to fix DebugReports, anyway this is another issue not 
directly linked to my point.  My point was that:
1) when one people already worked on something, the later one should 
communicate with the  former one to avoid duplicate effort
2) The patch should have some soaking time to be merged, say 24 hours, 
and people in other timezone can get an opportunity to review it.
>
> In addition, IMO the point you mentioned about not expose host file
> system to the front is the root cause of this bug. Many UI paths were
> broken because the paths set up by backend was not used or followed.

In most cases ,we should use relative path to hide the host file systems 
from the front users.  Only if it must, the absolute path can be used.  
I don't like the idea to change all the relative static path to absolute 
ones.  IMO, we can only use absolute path for the debugreport and 
screenshot path.  Even better, we can take more effort to re-organize 
the path to have a reasonable root for all of the path including 
debugreport and screenshot paths.

>
> Best regards,




More information about the Kimchi-devel mailing list