[Kimchi-devel] [PATCH 2/4] Add functions to check if a user/group exists

Crístian Viana vianac at linux.vnet.ibm.com
Thu Feb 27 15:43:15 UTC 2014


Am 27-02-2014 11:20, schrieb Rodrigo Trujillo:
>   Maybe the naming is wrong below.
The map key USER_ID actually contains the user name, not the ID. That is 
how the class User is already implemented. We can send another patch 
later to rename it but that is not the scope of this patch.
> You are passing the User ID and getpwnam expects the User name 
No, I am passing the user name because, as you said, getpwnam expects a 
user name.
> I did not test the patch manually,
I did.
> not sure if it will work.
It does :)
> Same problem that before, because you are
> passing the User name to User Class , which expects the User ID
No, it expects a user name.
> ... If this work, then the name of
> parameters should change
I agree. But in another patch. I am working on an existing code which 
has a variable named "userid" containing a user name.




More information about the Kimchi-devel mailing list