[Kimchi-devel] [PATCH V4] Issue#361:Bugfix disable the action button content when creating network

[Aline Manera]

On 06/18/2014 03:10 AM, Wen Wang wrote:
>
> On 06/18/2014 06:49 AM, Aline Manera wrote:
>> On 06/17/2014 07:20 PM, Aline Manera wrote:
>>> On 06/17/2014 06:22 PM, Aline Manera wrote:
>>>> Applied. Thanks.
>>>>
>>>> Regards,
>>>>
>>>> Aline Manera
>>>>
>>>> _______________________________________________
>>>> Kimchi-devel mailing list
>>>> Kimchi-devel at ovirt.org
>>>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>>>
>>> I've just noticed this patch changed the list border
>>>
>>>
>>>
>>> Please, send a patch to fix it ASAP
>>
>> After some investigation I figured out those "comments" were used for it
>>
>>     <span class='column column-name cell' 
>> title="{name}">{name}</span><!--
>>  --><span class='column column-state cell'><span class='network-state 
>> {state}'></span></span><!--
>>  --><span class='column column-type cell'>{type}</span><!--
>>  --><span class='column column-interface cell'>{interface}</span><!--
>>  --><span class='column column-space cell'>{addrSpace}</span><!--
>>  --><span class='column-action'>
>>
>> With the above code, the borders are properly displayed
>> But don't ask me why these "comments" are important :-)
> I did some research and found out that if the element <span> written 
> in different lines, the browser will add an extra space between each 
> <span></span>. With the method using comments that makes the browser 
> think these spans are written within oneline. I have sent a patch that 
> changed the layout back.

Thanks for the clarification!

>>
>>>
>>>
>>> _______________________________________________
>>> Kimchi-devel mailing list
>>> Kimchi-devel at ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140618/60b60cc3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/jpeg
Size: 22897 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20140618/60b60cc3/attachment.jpe>