[Kimchi-devel] [PATCH v3 0/2] Github bug #307: Add storage pool list

Daniel Barboza danielhb at linux.vnet.ibm.com
Tue Mar 4 11:16:56 UTC 2014


From: Daniel Henrique Barboza <danielhb at linux.vnet.ibm.com>

Changelog:
v3:
- rebase with master
v2:
- Fixing message ID

These patches fixes the bug where the list of storage pool
types can take a long time to appear. The solution used here
is to detach the view of such list with the return of the
JSON that loads the partition data.

To test this patch I recomend doing the following change in
src/kimchi/model/hosts.py:

+ import time

class PartitionsModel(object):
    def __init__(self, **kargs):
        pass

    def get_list(self):
+        time.sleep(10)
        result = disks.get_partitions_names()
        return result


The sleep(10) call will ensure that get_list (which returns the
partition data) will take at least 10 seconds to execute. It is
enough time to select the LOGICAL type and see how the UI is
working before and after the JSON call.


Daniel Henrique Barboza (2):
  Github bug #307: add storage pool type list - JS changes
  Github bug #307: storage pool type list - html and string changes

 po/en_US.po                              |   9 +-
 po/kimchi.pot                            |   8 +-
 po/pt_BR.po                              |   9 +-
 po/zh_CN.po                              |   9 +-
 ui/js/src/kimchi.storagepool_add_main.js | 174 ++++++++++++++++---------------
 ui/pages/i18n.html.tmpl                  |   5 +-
 ui/pages/storagepool-add.html.tmpl       |   7 +-
 7 files changed, 129 insertions(+), 92 deletions(-)

-- 
1.8.3.1




More information about the Kimchi-devel mailing list