[Kimchi-devel] [PATCH] Do not show a success msg when creating a template

Sheldon shaohef at linux.vnet.ibm.com
Mon Mar 10 08:39:19 UTC 2014


Reviewed-by: ShaoHe Feng <shaohef at linux.vnet.ibm.com>

  not seen this green message on my host.

But agree we should keep consistent.


On 03/08/2014 04:45 AM, Crístian Viana wrote:
> When the user creates a new template, a green success message is
> displayed on top of the screen. This behavior is not common in Kimchi;
> when an operation performs successfully, nothing is shown. Actually, the
> templates page is the only one that does that.
>
> In order to make Kimchi more consistent, remove the code that displays a
> success message when the user creates a new template.
>
> Signed-off-by: Crístian Viana <vianac at linux.vnet.ibm.com>
> ---
>   ui/js/src/kimchi.template_add_main.js | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/ui/js/src/kimchi.template_add_main.js b/ui/js/src/kimchi.template_add_main.js
> index 5fd6532..dbb3952 100644
> --- a/ui/js/src/kimchi.template_add_main.js
> +++ b/ui/js/src/kimchi.template_add_main.js
> @@ -365,7 +365,6 @@ kimchi.template_add_main = function() {
>                   };
>                   kimchi.createTemplate(data, function() {
>                       successNum++;
> -                    kimchi.message.success(i18n['KCHTMPL6001M'] + ': ' + isoInfo.name);
>                       $('input[value="' + isoInfo.isoId + '"]').prop('checked', false);
>                       $('.check-all>input').prop('checked', false);
>                       kimchi.doListTemplates();


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center




More information about the Kimchi-devel mailing list