[Kimchi-devel] [PATCH] Supplement to [PATCH v6 0/3] UI: Software Update Support

[Hongliang Wang]

On 03/13/2014 11:36 AM, Aline Manera wrote:
> On 03/13/2014 12:30 AM, Hongliang Wang wrote:
>> On 03/13/2014 05:51 AM, Adam King wrote:
>>> The original patch series leaves the "loading" image displayed over the
>>> debug reports indefinistly. This patch corrects that error, as well as
>>> centering the images over the grid.
>> Thanks for the fixes! Though I noticed it and sent a patch to fix it. 
>> Sorry for my late patch. See comments inline.
>
> Sorry, Hongliang! Just see your comments now
> I've just applied this patch set
>
OK. Let me send another patch to fix remaining issues.
>>>
>>> Signed-off-by: Adam King <rak at linux.vnet.ibm.com>
>>> ---
>>>   ui/css/theme-default/grid.css | 10 ++++++----
>>>   ui/js/src/kimchi.grid.js      |  2 +-
>>>   2 files changed, 7 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/ui/css/theme-default/grid.css 
>>> b/ui/css/theme-default/grid.css
>>> index 761d32f..958bdb0 100644
>>> --- a/ui/css/theme-default/grid.css
>>> +++ b/ui/css/theme-default/grid.css
>>> @@ -218,21 +218,23 @@
>>>       left: 0;
>>>       position: absolute;
>>>       right: 0;
>>
>>> +    top: 48px;
>> It's already calculated dynamically because there may be no title bar 
>> or toolbar. Don't hard-code here.
>>>   }
>>>
>>>   .grid-loading {
>>>       bottom: 0;
>>
>>> -    height: 68px;
>>> +    height: 100%;
>>>       left: 0;
>>>       margin: auto;
>>>       right: 0;
>>>       text-align: center;
>>>       top: 0;
>>> -    width: 49px;
>>> +    width: 100%;
>> Adding a "position: absolute;" will center it both horizontally and 
>> vertically.
>>>   }
>>>
>>>   .grid-loading-icon {
>>>       background: url("../images/theme-default/kimchi-loading.gif") 
>>> no-repeat left top;
>>> -    height: 48px;
>>> -    width: 49px;
>>> +    height: 100%;
>>> +    width: 100%;
>>> +    background-position: center;
>> Don't change the size of icon.
>>>   }
>>> diff --git a/ui/js/src/kimchi.grid.js b/ui/js/src/kimchi.grid.js
>>> index c53e584..2e3d0ed 100644
>>> --- a/ui/js/src/kimchi.grid.js
>>> +++ b/ui/js/src/kimchi.grid.js
>>> @@ -54,7 +54,7 @@ kimchi.widget.Grid = function(params) {
>>>             '<div class="grid-resizer hidden"></div>',
>>>           '</div>',
>>>           '<div class="grid-footer"></div>',
>>> -        '<div class="grid-mask">',
>>> +        '<div class="grid-mask hidden">',
>> That's right.
>>>               '<div class="grid-loading">',
>>>                   '<div class="grid-loading-icon"></div>',
>>>                   '<div class="grid-loading-text"></div>',
>>
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>