[Kimchi-devel] [PATCH V4 0/4] check the python code with pyflakes

[Shu Ming]

Reviewed-by: Shu Ming <shuming at linux.vnet.ibm.com>
2014-03-21Fri的 07:34 +0800，shaohef at linux.vnet.ibm.com：
> From: ShaoHe Feng <shaohef at linux.vnet.ibm.com>
> 
> V3 -> V4
> address Rodrigo's comment.
> add delete the cloned template in rollback. 
> 
> V2 -> V3
> address zhengsheng's comment.
> improve the SKIP_PYFLAKES_ERR list.
> 
> V1 -> V2
> address Crístian'comment:
> remove the whole statement "info = self._get_vm(name).inf"
> address ming's comment:
> break down the patch into small patches by the pyflakes error.
> 
> Pyflakes analyzes programs and detects various errors. It works by
> parsing the source file, not importing it, so it is safe to use on
> modules with side effects. It's also much faster.
> 
> This is important to improve the code quality.
> 
> 
> ShaoHe Feng (4):
>   make pyflakes happly, remove the unused import module
>   make pyflakes happly, remove unused availables
>   add template_delete to rollback after create a template
>   run pyflakes when make check
> 
>  Makefile.am                      | 7 +++++++
>  configure.ac                     | 7 +++++++
>  contrib/DEBIAN/control.in        | 1 +
>  contrib/kimchi.spec.fedora.in    | 1 +
>  docs/README.md                   | 6 +++---
>  src/kimchi/control/plugins.py    | 2 +-
>  src/kimchi/featuretests.py       | 2 --
>  src/kimchi/mockmodel.py          | 5 ++---
>  src/kimchi/model/storagepools.py | 2 +-
>  src/kimchi/screenshot.py         | 1 -
>  src/kimchi/template.py           | 1 -
>  tests/test_model.py              | 2 ++
>  tests/test_server.py             | 1 -
>  ui/pages/help/gen-index.py       | 1 -
>  14 files changed, 25 insertions(+), 14 deletions(-)
>