[Kimchi-devel] [PATCHv2 2/2] StoragePool Edit: Update json schema

[Sheldon]

On 05/04/2014 06:13 PM, lvroyce at linux.vnet.ibm.com wrote:
> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>
> Update json schema to return proper error when empty disk string
> is passed.
>
> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
> ---
>   src/kimchi/API.json | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/kimchi/API.json b/src/kimchi/API.json
> index 38e9607..b6ddc0f 100644
> --- a/src/kimchi/API.json
> +++ b/src/kimchi/API.json
> @@ -139,7 +139,8 @@
>                       "type": "array",
>                       "items": { "type": "string" },
>                       "minItems": 1,
> -                    "uniqueItems": true
> +                    "uniqueItems": true,
> +                    "error": "KCHPOOL0018E"
seems KCHPOOL0018E is not very good here.
the jsonschema Validator can check and raise the right error message.
but now, our exception mechanism swallow the error message instead of 
catch it.
would you like to improve it?
>                   }
>               }
>           },


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center