[Kimchi-devel] [PATCHv2] Issue#348: Add loading icon when nfs mount is in progress

[Sheldon]

On 05/26/2014 09:34 PM, Sheldon wrote:
> after test
> 1.
> I can close the create window during the progress.
but the pool can be created successfully.
> 2.
> I still can type all text of the create window
> 3.
> In my option, the progress info and loading icon is not so obviously
>
> On 05/26/2014 11:21 AM, lvroyce at linux.vnet.ibm.com wrote:
>> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>>
>> v1>v2, Improve feedback msg according to Hongliang's comments.
>>
>> Add loading icon to indicate nfs mount in progress,
>> when error or normal response returns,
>> close create window.
>>
>> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
>> ---
>>   ui/js/src/kimchi.storagepool_add_main.js | 2 ++
>>   ui/pages/storagepool-add.html.tmpl       | 6 ++++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/ui/js/src/kimchi.storagepool_add_main.js 
>> b/ui/js/src/kimchi.storagepool_add_main.js
>> index 86dbe7f..6b77bd8 100644
>> --- a/ui/js/src/kimchi.storagepool_add_main.js
>> +++ b/ui/js/src/kimchi.storagepool_add_main.js
>> @@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () {
>>           kimchi.message.error.code('KCHPOOL6005E');
>>           return false;
>>       }
>> +    $('#nfs-mount-loading').removeClass('hidden');
>>       return true;
>>   };
>>
>> @@ -295,6 +296,7 @@ kimchi.addPool = function(event) {
>>                   kimchi.window.close();
>>               }, function(err) {
>>                   kimchi.message.error(err.responseJSON.reason);
>> +                kimchi.window.close();
>>               });
>>           }
>>       }
>> diff --git a/ui/pages/storagepool-add.html.tmpl 
>> b/ui/pages/storagepool-add.html.tmpl
>> index 977db66..b033b36 100644
>> --- a/ui/pages/storagepool-add.html.tmpl
>> +++ b/ui/pages/storagepool-add.html.tmpl
>> @@ -91,6 +91,12 @@
>>                                       </ul>
>>                                   </div>
>>                               </div>
>> +                            <div class="hidden" id="nfs-mount-loading">
>> +                                <p class="text-help">
>> +                                    $_("Trying to mount NFS export 
>> path. It may take several seconds.")
>> +                                    <img src = 
>> "../images/theme-default/loading.gif" />
>> +                                </p>
>> +                            </div>
>>                           </div>
>>                       </section>
>>                   </div>
>
>


-- 
Thanks and best regards!

Sheldon Feng(冯少合)<shaohef at linux.vnet.ibm.com>
IBM Linux Technology Center