[Kimchi-devel] [PATCH] Issue#348: Add loading icon when nfs mount is in progress

[Royce Lv]

On 2014年05月28日 23:24, Christy Perez wrote:
> Tested-By: Christy Perez <christy at linux.vnet.ibm.com>
>
> This works for me. One tiny aesthetic thing, though. It looks like there
> could be a little space above the text & swirl image. The image is cut
> off by maybe a pixel at the top in my view (Firefox on F20).
Yes, thanks for review, Christy, Hongliang and sheldon had pointed that too.
I will resend this patch with other points to fix.
Pls review after that.
>
>
> On Fri, 2014-05-23 at 16:18 +0800, lvroyce at linux.vnet.ibm.com wrote:
>> From: Royce Lv <lvroyce at linux.vnet.ibm.com>
>>
>> Add loading icon to indicate nfs mount in progress,
>> when error or normal response returns,
>> close create window.
>>
>> Signed-off-by: Royce Lv <lvroyce at linux.vnet.ibm.com>
>> ---
>>   ui/js/src/kimchi.storagepool_add_main.js | 2 ++
>>   ui/pages/storagepool-add.html.tmpl       | 6 ++++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/ui/js/src/kimchi.storagepool_add_main.js b/ui/js/src/kimchi.storagepool_add_main.js
>> index 86dbe7f..6b77bd8 100644
>> --- a/ui/js/src/kimchi.storagepool_add_main.js
>> +++ b/ui/js/src/kimchi.storagepool_add_main.js
>> @@ -198,6 +198,7 @@ kimchi.validateNfsForm = function () {
>>           kimchi.message.error.code('KCHPOOL6005E');
>>           return false;
>>       }
>> +    $('#nfs-mount-loading').removeClass('hidden');
>>       return true;
>>   };
>>
>> @@ -295,6 +296,7 @@ kimchi.addPool = function(event) {
>>                   kimchi.window.close();
>>               }, function(err) {
>>                   kimchi.message.error(err.responseJSON.reason);
>> +                kimchi.window.close();
>>               });
>>           }
>>       }
>> diff --git a/ui/pages/storagepool-add.html.tmpl b/ui/pages/storagepool-add.html.tmpl
>> index 977db66..b0bc36d 100644
>> --- a/ui/pages/storagepool-add.html.tmpl
>> +++ b/ui/pages/storagepool-add.html.tmpl
>> @@ -91,6 +91,12 @@
>>                                       </ul>
>>                                   </div>
>>                               </div>
>> +                            <div class="hidden" id="nfs-mount-loading">
>> +                                <p class="text-help">
>> +                                    $_("Server trying mount nfs export path...")
>> +                                    <img src = "../images/theme-default/loading.gif" />
>> +                                </p>
>> +                            </div>
>>                           </div>
>>                       </section>
>>                   </div>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>