[Kimchi-devel] [PATCH 0/7] Use the common get_disk_xml() to generate VMTemplate disks

[Aline Manera]

On 10/31/2014 06:09 PM, Daniel H Barboza wrote:
> Reviewed-by: Daniel Barboza <danielhb at linux.vnet.ibm.com>
>
> Just a comment: this patch
>
> [PATCH 5/7] Change VMTemplate._get_disks_xml() to    use the common 
> get_disk_xml()
>
> will need to be rebased with the changes of the disk format in template.
>
>

Thanks, Daniel!

The rebased patch set can be found on my branch if you want to test it.

Repository; https://github.com/alinefm/kimchi
Branch: alinefm/vmtemplate-refactor

>
> On 10/31/2014 03:22 PM, Aline Manera wrote:
>> Aline Manera (7):
>>    Make disk type an optional parameter on get_disk_xml()
>>    Set guest disk cache to none to support live migration
>>    Change VMTemplate._get_scsi_disks_xml() to use the common
>>      get_disk_xml()
>>    Change VMTemplate._get_iscsi_disks_xml() to use the common
>>      get_disk_xml()
>>    Change VMTemplate._get_disks_xml() to use the common get_disk_xml()
>>    Change VMTemplate._get_disks_xml() to handle all type of disks
>>    Remove VMTemplate._get_scsi_disks_xml() and
>>      VMTemplate._get_iscsi_disks_xml()
>>
>>   src/kimchi/model/vmstorages.py |   1 +
>>   src/kimchi/vmtemplate.py       | 108 
>> ++++++++++++-----------------------------
>>   src/kimchi/xmlutils/disk.py    |  10 +++-
>>   tests/test_model.py            |   3 +-
>>   4 files changed, 42 insertions(+), 80 deletions(-)
>>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>