[Kimchi-devel] [v2] UI: Guest Snapshot

Crístian Viana vianac at linux.vnet.ibm.com
Tue Nov 18 20:08:57 UTC 2014


Here are my comments:

- When creating a snapshot, the loading icon makes the snapshot entry 
line a little bigger.

- After creating a snapshot, the UI blinks to update the list of 
snapshots. That's very noticeable.

- When deleting the current snapshot, the UI doesn't update the new 
current snapshot. Just call GET /vms/<vm-name>/snapshots/current again 
and draw the check icon on the new current snapshot.

- When deleting a snapshot, you need to disable the buttons just like 
you did when reverting o a snapshot.

You need to apply the patchset I sent today ("Snapshot bugfixes") to get 
the fix for some of the bugs you reported on your last e-mail. The only 
one I haven't worked out yet is creating a snapshot on a VM with a raw 
disk. For now, you need to create a snapshot on a VM created by Kimchi, 
which uses a qcow2 image.

On 18-11-2014 08:49, huoyuxin at linux.vnet.ibm.com wrote:
> From: Yu Xin Huo <huoyuxin at linux.vnet.ibm.com>
>
> Signed-off-by: Yu Xin Huo <huoyuxin at linux.vnet.ibm.com>




More information about the Kimchi-devel mailing list