[Kimchi-devel] [PATCH] Addition of custom mac address field for interfaces v3

Crístian Viana vianac at linux.vnet.ibm.com
Wed Oct 1 19:59:28 UTC 2014


Oh, and I forgot to add another thing. With this patch, the MAC address
becomes required when the user adds a new NIC. If I don't type an
address, I get the following error:


Invalid MAC address format. Expected a 12 character hexadecimal value
separated by colons(:)


I think that's a bad thing because most of the times the user doesn't
care about which MAC address is assigned to their NIC. So IMO if the
user leaves that field blank, a random MAC should be generated, just
like before. But if they type something, that must be validated indeed.

I see that there's code dealing exactly with that, but it's not
working with me.

On Qua, 2014-10-01 at 10:03 -0500, bbaude at redhat.com wrote:

> From: Brent Baude <bbaude at redhat.com>
> 
> Fixed json issue and included comments from pvital


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20141001/14c67a24/attachment.html>


More information about the Kimchi-devel mailing list