[Kimchi-devel] [PATCH 0/2 V4] Detect and enable help page from plugins tabs

Paulo Ricardo Paz Vital pvital at linux.vnet.ibm.com
Fri Oct 3 13:30:07 UTC 2014


Excepted by the necessary rebase (easy to fix), the patches are good!
-- 
Tested-by: Paulo Vital <pvital at linux.vnet.ibm.com>
Reviewed-by: Paulo Vital <pvital at linux.vnet.ibm.com>


On Tue, 2014-09-30 at 15:37 -0300, Rodrigo Trujillo wrote:
> This patch set changes the way Kimchi loads Help pages of the tabs of
> the plugins.
> It also changes the Sample plugin, in order to demonstrate and show
> properly how to configure the a Help page
> 
> Rodrigo Trujillo (2):
>   Fix problems to open plugin's help pages
>   Changes in sample plugin to fix and improve help
> 
>  configure.ac                                       |  1 -
>  plugins/sample/Makefile.am                         | 12 +++++
>  plugins/sample/sample.conf.in                      |  5 ++
>  plugins/sample/ui/config/tab-ext.xml               | 11 ++++-
>  plugins/sample/ui/pages/Makefile.am                |  2 +-
>  .../sample/ui/pages/help/en_US/sample-tab1.html    |  1 +
>  .../sample/ui/pages/help/en_US/sample-tab2.html    |  1 +
>  plugins/sample/ui/pages/sample-tab1.html.tmpl      | 30 ++++++++++++
>  plugins/sample/ui/pages/sample-tab2.html.tmpl      | 30 ++++++++++++
>  plugins/sample/ui/pages/tab.html.tmpl              | 30 ------------
>  ui/js/src/kimchi.main.js                           | 53 ++++++++++++++++------
>  11 files changed, 129 insertions(+), 47 deletions(-)
>  create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab1.html
>  create mode 100644 plugins/sample/ui/pages/help/en_US/sample-tab2.html
>  create mode 100644 plugins/sample/ui/pages/sample-tab1.html.tmpl
>  create mode 100644 plugins/sample/ui/pages/sample-tab2.html.tmpl
>  delete mode 100644 plugins/sample/ui/pages/tab.html.tmpl
> 




More information about the Kimchi-devel mailing list