[Kimchi-devel] [PATCH 0/2] Create a xmlutils module to hold all the XML manipulation

[Daniel H Barboza]

Reviewed-by: Daniel Barboza <danielhb at linux.vnet.ibm.com>

On 10/16/2014 11:01 AM, Aline Manera wrote:
> It is the first step to do a VMTemplate refactor, as all the XML manipulation
> will be in a single place.
>
> Aline Manera (2):
>    Create a xmlutils module to hold all the XML manipulation
>    Move networkxml.py to xmlutils module and update it to use
>      lxml.builder
>
>   src/kimchi/config.py.in            |   2 +-
>   src/kimchi/model/host.py           |   4 +-
>   src/kimchi/model/hostdev.py        |   2 +-
>   src/kimchi/model/networks.py       |  30 ++++-----
>   src/kimchi/model/storagepools.py   |  16 ++---
>   src/kimchi/model/storagevolumes.py |   5 +-
>   src/kimchi/model/templates.py      |   8 +--
>   src/kimchi/model/vms.py            |  21 +++---
>   src/kimchi/networkxml.py           | 127 -------------------------------------
>   src/kimchi/xmlutils.py             |  63 ------------------
>   src/kimchi/xmlutils/__init__.py    |  18 ++++++
>   src/kimchi/xmlutils/network.py     | 123 +++++++++++++++++++++++++++++++++++
>   src/kimchi/xmlutils/utils.py       |  63 ++++++++++++++++++
>   tests/test_networkxml.py           |  29 ++++-----
>   tests/test_vmtemplate.py           |   2 +-
>   15 files changed, 261 insertions(+), 252 deletions(-)
>   delete mode 100644 src/kimchi/networkxml.py
>   delete mode 100644 src/kimchi/xmlutils.py
>   create mode 100644 src/kimchi/xmlutils/__init__.py
>   create mode 100644 src/kimchi/xmlutils/network.py
>   create mode 100644 src/kimchi/xmlutils/utils.py
>