[Kimchi-devel] [PATCH v7 0/3] Backend support for templates with sockets, cores, and threads

Christy Perez christy at linux.vnet.ibm.com
Thu Oct 23 20:57:24 UTC 2014


v6->v7
- Add unit tests
- Rebase

v5->v6:
- Change cpu_info to empty dict instead of empty string if not specified
- Split translations into different commit

v4->v5:
- Fix format issues
- Remove if check for cpu_info in control, and set cpu_info
  to the empty string in model if None
- Add format requirements error for topology requirements.
- Add new error to toplogy in API.json
- Update po files

v3->v4:
- Remove the unused cpu_ elements from common_spec
- Pass new_t into validate function to reduce complexity
- Rearrange code to decrese indents in _get_cpu_xml

v2->v3:
- Set vcpus based on topology, if specified.
- Move the update cpu+topology validation out to a function
  for redability
- Add a minimum value of 1 for topology values
- Leave new English error msg as empty string
- Update the API documentation on cpu defaults

v1->v2:
- Added a check to make sure that vcpus = sockets*cores*threads
- Set individual topoology params to required in API.json
- Change the topology object types from string to integer
- Always return cpu_info from templates lookup()
- Removed check for cpu_info in to_vm_xml
- Build cpu_info xml using lxml.builder instead of string
- CPU and topology verification on template update

Christy Perez (3):
  Backend support for templates with sockets, cores, and threads
  model test for updating template
  Translations for new cpu_info messages

 docs/API.md                     | 13 ++++++-
 po/de_DE.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/en_US.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/es_ES.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/fr_FR.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/it_IT.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/ja_JP.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/kimchi.pot                   | 76 +++++++++++++++++++++++++++++++++++----
 po/ko_KR.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/pt_BR.po                     | 75 ++++++++++++++++++++++++++++++++++----
 po/ru_RU.po                     | 76 +++++++++++++++++++++++++++++++++++----
 po/zh_CN.po                     | 79 +++++++++++++++++++++++++++++++++++------
 po/zh_TW.po                     | 76 +++++++++++++++++++++++++++++++++++----
 src/kimchi/API.json             | 36 +++++++++++++++++--
 src/kimchi/control/templates.py | 31 ++++++++--------
 src/kimchi/i18n.py              |  2 ++
 src/kimchi/model/templates.py   | 32 +++++++++++++++++
 src/kimchi/osinfo.py            |  5 ++-
 src/kimchi/vmtemplate.py        | 16 +++++++++
 tests/test_model.py             | 25 +++++++++++++
 20 files changed, 966 insertions(+), 108 deletions(-)

-- 
1.9.3




More information about the Kimchi-devel mailing list