[Kimchi-devel] [PATCH v2 0/4] UI: Download Remote Image Feature

Aline Manera alinefm at linux.vnet.ibm.com
Mon Sep 15 21:33:31 UTC 2014


Hongliang,

I've just sent a V3 of this patch set (it is your V2 + [Kimchi-devel] 
[PATCH] Adjustments on upload/download UI).
Please, review and test it so we can merge it for 1.3 release.

As many issues were found on upload feature it will be disabled for 1.3 
release due the time.
After 1.3 release we can focus on solve those issues and then enable 
upload option.

The download UI *must* be merged by Web to be on 1.3. Please, take a 
look on V3.


On 09/12/2014 06:42 AM, Hongliang Wang wrote:
> Implemented download remote image feature.
>
> v1 -> v2:
>    2a) Disabled add volume for inactive and iscsi/scsi pools
>        (Aline's comment)
>
>    2b) Removed progress bar after upload/download finished
>        (Aline & Cristian's comment)
>
>    2c) Changed the button label to "Add" from "OK"
>        (Cristian's comment)
>
>    2d) Made add volume button behave correctly (enabled/disabled)
>        (Cristian's comment)
>
>    2e) Removed some code redundent
>        (Aline & Cristian's comment)
>
> Hongliang Wang (4):
>    Storage Pool Add Volume UI: Add APIs to kimchi.api.js
>    Storage Pool Add Volume UI: Add i18n Strings
>    Storage Pool Add Volume UI: Implement Download/Upload Volume Function
>    Storage Pool Add Volume UI: Connect the Feature in Storage Tab
>
>   ui/css/theme-default/storage.css                |  31 ++-
>   ui/css/theme-default/storagepool-add-volume.css |  36 ++++
>   ui/js/src/kimchi.api.js                         |  37 ++++
>   ui/js/src/kimchi.storage_main.js                | 116 ++++++++++-
>   ui/js/src/kimchi.storagepool_add_volume_main.js | 243 ++++++++++++++++++++++++
>   ui/pages/i18n.json.tmpl                         |   4 +
>   ui/pages/storagepool-add-volume.html.tmpl       |  80 ++++++++
>   ui/pages/tabs/storage.html.tmpl                 |  12 +-
>   8 files changed, 549 insertions(+), 10 deletions(-)
>   create mode 100644 ui/css/theme-default/storagepool-add-volume.css
>   create mode 100644 ui/js/src/kimchi.storagepool_add_volume_main.js
>   create mode 100644 ui/pages/storagepool-add-volume.html.tmpl
>




More information about the Kimchi-devel mailing list