[Kimchi-devel] [PATCH V2] Bugfix:#424 Edit Template, "Disk (GB)" is changing with storage pool

Wen Wang wenwang at linux.vnet.ibm.com
Fri Sep 19 09:53:18 UTC 2014


From: Wen Wang <wenwang at linux.vnet.ibm.com>

V1 -> V2:
Considering iSCSI and SCSI situation that we need to have the input box
disabled when choosing iSCSI and SCSI for storage pool and enable when
choosing others.

This patch fix the bug that value of "Disk(GB)" input box is changing
with the item of "Storage Pool" in "Templates" --> "Actions" --> "Edit"
-->"Edit Templates" dialogue. This might be comfusing to user when
changing the "Storage Pool", "Disk(GB)" is changed with it without even
notice. This might confuse the users and is not necessary. Solved by
removing the change.

Signed-off-by: Wen Wang <wenwang at linux.vnet.ibm.com>
---
 ui/js/src/kimchi.template_edit_main.js |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/ui/js/src/kimchi.template_edit_main.js b/ui/js/src/kimchi.template_edit_main.js
index cb43091..8133878 100644
--- a/ui/js/src/kimchi.template_edit_main.js
+++ b/ui/js/src/kimchi.template_edit_main.js
@@ -131,13 +131,6 @@ kimchi.template_edit_main = function() {
                 kimchi.message.error(err.responseJSON.reason);
             });
         } else {
-            if (origPool == storagepool) {
-                // Previous disk size value
-                $('input[name="disks"]', templateEditForm).val(origDisks[0].size);
-            } else {
-                // Default disk size value
-                $('input[name="disks"]', templateEditForm).val(10);
-            }
             $('input[name="disks"]', templateEditForm).removeAttr('disabled');
         }
     });
-- 
1.7.1




More information about the Kimchi-devel mailing list