[Kimchi-devel] [PATCH] Set qcow2 as default disk format in new templates

[Rodrigo Trujillo]

Will do.  However, the tests will be done in test_template.py
Thanks

On 04/16/2015 10:30 AM, Crístian Viana wrote:
> I'd suggest updating tests/test_osinfo.py to check for that value, so we
> make sure that format is actually the default format.
>
> On Tue, Apr 14, 2015 at 3:23 AM Rodrigo Trujillo <
> rodrigo.trujillo at linux.vnet.ibm.com> wrote:
>
>> Users are allowed to provide disk format when creating a new Template.
>> However this is optional. This option sets qcow2 as default disk format
>> for every new Template created.
>>
>> Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>
>> ---
>>   src/kimchi/osinfo.py | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/kimchi/osinfo.py b/src/kimchi/osinfo.py
>> index 3c31346..ede2541 100644
>> --- a/src/kimchi/osinfo.py
>> +++ b/src/kimchi/osinfo.py
>> @@ -33,7 +33,8 @@ SUPPORTED_ARCHS = {'x86': ('i386', 'i686', 'x86_64'),
>>                      'ppc64le': ('ppc64le')}
>>
>>
>> -common_spec = {'cpus': 1, 'memory': 1024, 'disks': [{'index': 0, 'size':
>> 10}],
>> +common_spec = {'cpus': 1, 'memory': 1024, 'disks': [{'index': 0, 'size':
>> 10,
>> +                                                     'format': 'qcow2'}],
>>                  'cdrom_bus': 'ide', 'cdrom_index': 2, 'mouse_bus': 'ps2'}
>>
>>
>> --
>> 2.1.0
>>
>> _______________________________________________
>> Kimchi-devel mailing list
>> Kimchi-devel at ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20150416/ceaa0f1e/attachment.html>