[Kimchi-devel] [PATCH 3/3] Add a warn about NM running in the system.

Jose Ricardo Ziviani joserz at linux.vnet.ibm.com
Fri Apr 17 19:29:27 UTC 2015


 - If NetworkManager is running when user is trying to create a bridge,
   it will warn about problems that could happen, asking the user to
   turn NM service off while dealing with bridge creation.

Signed-off-by: Jose Ricardo Ziviani <joserz at linux.vnet.ibm.com>
---
 ui/js/src/kimchi.network.js | 5 +++++
 ui/pages/i18n.json.tmpl     | 1 +
 2 files changed, 6 insertions(+)

diff --git a/ui/js/src/kimchi.network.js b/ui/js/src/kimchi.network.js
index 90fb62b..be140e8 100644
--- a/ui/js/src/kimchi.network.js
+++ b/ui/js/src/kimchi.network.js
@@ -323,6 +323,11 @@ kimchi.setDefaultNetworkType = function(isInterfaceAvail) {
         kimchi.enableBridgeOptions(false);
         $("#networkBriDisabledLabel").show();
     } else {
+        kimchi.getCapabilities(function(result) {
+            if (result && result.nm_running) {
+                kimchi.message.warn(i18n['KCHNET6001W']);
+            }
+        });
         $("#bridgeOptions").slideDown(100);
         $("#networkVlanID").toggle(false);
         $("#labelNetworkVlanID").toggle(false);
diff --git a/ui/pages/i18n.json.tmpl b/ui/pages/i18n.json.tmpl
index a7f9daf..5e7dc4f 100644
--- a/ui/pages/i18n.json.tmpl
+++ b/ui/pages/i18n.json.tmpl
@@ -153,6 +153,7 @@
     "KCHNET6002M": "$_("This action will interrupt network connectivity for any virtual machine that depend on this network.")",
     "KCHNET6003M": "$_("Create a network")",
     "KCHNET6004M": "$_("This network is not persistent. Instead of stop, this action will permanently delete it. Would you like to continue?")",
+    "KCHNET6001W": "$_("The bridged VLAN tag may not work well with NetworkManager enabled. You can disable it or add NM_CONTROLLER=NO to the network file configuration.")",
 
     "KCHPOOL6001M": "$_("This will permanently delete the storage pool. Would you like to continue?")",
     "KCHPOOL6002M": "$_("This storage pool is empty.")",
-- 
1.9.1




More information about the Kimchi-devel mailing list