[Kimchi-devel] [Kimchi] Remove pyflakes checking on .git

Daniel Henrique Barboza dhbarboza82 at gmail.com
Tue Dec 29 00:48:50 UTC 2015


The thing is that I for one am not working using the submodule system
of WoK - I clone each repository individually. In my case there is a .git
dir and your patch is eliminating pyflakes checking there.

If we decide that this checking in .git dir is unnecessary (TBH I don't
know why we do that, but I guess there's a fair reason to), we
can apply your patch no problem. Otherwise you would need to
add a 'test -d' check to see if the dir exists and, if it's not the case,
execute another pyflakes command to not include the .git dir.


On 12/28/2015 03:51 PM, Ramon Medeiros wrote:
> .git isn't a directory on submodles, it's handler for a directory in
> Wok. This will avoid this kind of error:
>
> ./.git:1:7: invalid syntax
> gitdir: ../../../../.git/modules/src/wok/plugins/<plugin>
>        ^
>
> Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
> ---
>   Makefile.am | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 1c5af68..bb3311b 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -59,7 +59,7 @@ I18N_FILES = ./i18n.py \
>   
>   check-local:
>   	contrib/check_i18n.py $(I18N_FILES)
> -	find . -path './.git' -prune -type f -o \
> +	find . -path -prune -type f -o \
>   		-name '*.py' -o -name '*.py.in'  | xargs $(PYFLAKES) | \
>   		while read LINE; do echo "$$LINE"; false; done
>   




More information about the Kimchi-devel mailing list