[Kimchi-devel] [PATCH] <Fix problems of edit a guest containssnapshots>

Zongmei Gou gouzongmei at 163.com
Thu Jan 8 01:38:49 UTC 2015


Hi,Crístian

I've read your patch, which has solved the snapshots restore problems more clearly. I agree with you that we've already fixed this issue in separate patches, and I need to make some changes for the formatting issues and test case.

My patch will be responsible for the url redirect problem, which modifies base.py and function 'revert' in vmsnapshots.py.

Besides, I found there are two points need to pay attention to:

1. snap.listAllChildren() in _backup_snapshots.py need flag in older libvirt versions, as I used "0.10.2", it raised "listAllChildren() takes exactly 2 arguments (1 given)" 

2. UI transfer param 'name' no matter you update vm name or not (of course while you edit a vm), so do we only need to bakup and restore the snapshots while vm name is really updated ?

Best regards,
Zongmei Gou
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20150108/6ab36f7a/attachment.html>


More information about the Kimchi-devel mailing list