[Kimchi-devel] [PATCH 2/2] Review changes for Kimchi

Aline Manera alinefm at linux.vnet.ibm.com
Fri Jul 3 12:39:56 UTC 2015



On 30/06/2015 19:48, Kersten wrote:
> Made changes to 3 files per comments from Aline.
>
> Signed-off-by: Kersten <kersten at us.ibm.com>
> ---
>   ui/pages/help/en_US/guests.dita    | 30 +++++++++++++++---------------
>   ui/pages/help/en_US/storage.dita   |  8 ++++----
>   ui/pages/help/en_US/templates.dita | 15 +++++++++------
>   3 files changed, 28 insertions(+), 25 deletions(-)
>
> diff --git a/ui/pages/help/en_US/guests.dita b/ui/pages/help/en_US/guests.dita
> index 7d0d453..45cf7da 100644
> --- a/ui/pages/help/en_US/guests.dita
> +++ b/ui/pages/help/en_US/guests.dita
> @@ -10,14 +10,14 @@ https://w3.opensource.ibm.com/projects/dita-cshelp/-->
>   <cshelp id="kimhvirtm" xml:lang="en-us">
>   <title>Guests</title>
>   <shortdesc>The <wintitle>Guests</wintitle> page lists the defined
> -guests or virtual machines.</shortdesc>
> +guests for your server.</shortdesc>
>   <csbody>
>   <p>For each guest, the following information is displayed:<dl><dlentry>
>   <dt>Name</dt>
> -<dd>Name of the virtual machine.</dd>
> +<dd>Name of the guest.</dd>
>   </dlentry><dlentry>
>   <dt>CPU</dt>
> -<dd>Percentage of processor utilization in the virtual machine.</dd>
> +<dd>Percentage of processor utilization in the guest.</dd>
>   </dlentry><dlentry>
>   <dt>Disk I/O</dt>
>   <dd>Disk input/output transmission rate in KB per seconds.</dd>
> @@ -53,16 +53,16 @@ existing guest. Guests can be edited only while stopped.</li>
>   <li>Select <uicontrol>Power Off</uicontrol> to force an immediate
>   shut down of the guest.</li>
>   <li>Select <uicontrol>Delete</uicontrol> to delete the guest.</li>
> -</ul>To create a guest, or virtual machine, click the <uicontrol>plus
> -(+)</uicontrol> icon on the page.</p>
> +</ul>To create a guest, click the <uicontrol>plus (+)</uicontrol> icon
> +on the page.</p>
>   </csbody>
>   <cshelp id="kimhvirtmcrt" xml:lang="en-us">
> -<title>Create a guest (virtual machine)</title>
> +<title>Create a guest</title>
>   <shortdesc>Create a guest by using an existing template.</shortdesc>
>   <csbody>
>   <p> <ol>
> -<li>Type the name to be used to identify the virtual machine.</li>
> -<li rev="rev1">Select a template. <ul>
> +<li>Type the name to be used to identify the guest.</li>
> +<li>Select a template. <ul>
>   <li>If templates exist, select from displayed templates.</li>
>   <li>If no templates exist, click <uicontrol>Create a template</uicontrol> to
>   create a template.</li>
> @@ -73,9 +73,9 @@ create a template.</li>
>   </cshelp>
>   <cshelp id="kimhvirtmedit" xml:lang="en-us">
>   <title>Edit guest</title>
> -<shortdesc>Edit the properties of an existing virtual machine. Some
> -properties can be edited only while guest is stopped. Others will
> -take effect in next boot.</shortdesc>
> +<shortdesc>Edit the properties of an existing guest. Some properties
> +can be edited only while guest is stopped. Others will take effect
> +in next boot.</shortdesc>
>   <csbody>
>   <dl><dlentry>
>   <dt>General</dt>
> @@ -124,11 +124,11 @@ guest.</li>
>   iSCSI volumes or if the target pool does not have enough space, the
>   clone will be created on a default storage pool. </note></li>
>   </ol>
> -<p>A guest appears in your list with the label "cloning..." When the
> -process is complete, the cloned guest is available to use.</p><?Pub
> -Caret 54?>
> +<p>A guest appears in your list with the label <uicontrol>Cloning...</uicontrol> When
> +the process is complete, the cloned guest is available to use.</p><?Pub
> +Caret 45?>
>   </csbody>
>   </cshelp>
>   <?tm 1391540919 3?>
>   </cshelp>
> -<?Pub *0000005359?>
> +<?Pub *0000005287?>
> diff --git a/ui/pages/help/en_US/storage.dita b/ui/pages/help/en_US/storage.dita
> index e6f995d..53d1404 100644
> --- a/ui/pages/help/en_US/storage.dita
> +++ b/ui/pages/help/en_US/storage.dita
> @@ -94,16 +94,16 @@ pool is created, it will be created for you.</li>
>   </cshelp>
>   <cshelp id="kimhdefstor" xml:lang="en-us">
>   <title>Add volume</title>
> -<shortdesc>Adds volume to a storage pool.</shortdesc><?Pub Caret 0?>
> +<shortdesc>Adds volume to a storage pool.</shortdesc>
>   <csbody>
>   <dl><dlentry>
>   <dt>Fetch from remote URL</dt>
> -<dd>Specifies a location to upload the volume from. For example: <filepath>https://my-server/fedora22.img</filepath>.</dd>
> +<dd>Specifies a location to download the volume from. For example: <filepath>https://my-server/fedora22.img</filepath>.</dd>
>   </dlentry><dlentry>
>   <dt>Upload a file</dt>
>   <dd>Specifies a location on your local system.</dd>
> -</dlentry></dl>
> +</dlentry></dl><?Pub Caret 57?>
>   </csbody>
>   </cshelp>
>   </cshelp>
> -<?Pub *0000004413?>
> +<?Pub *0000004416?>
> diff --git a/ui/pages/help/en_US/templates.dita b/ui/pages/help/en_US/templates.dita
> index 1c03016..ad3747c 100644
> --- a/ui/pages/help/en_US/templates.dita
> +++ b/ui/pages/help/en_US/templates.dita
> @@ -55,7 +55,7 @@ You can select multiple networks.</dd>
>   <dd>In the <uicontrol>CPU Number</uicontrol> field, specify the number
>   of processors that are defined for the template.</dd>
>   <dd>Select to Manually set CPU topology for each guest.</dd>
> -</dlentry></dl><?Pub Caret 322?>
> +</dlentry></dl>
>   </csbody>
>   </cshelp>
>   <cshelp id="kimhaddtempl">
> @@ -69,16 +69,19 @@ ISO image to 'ISO' storage pool for following discovery.</shortdesc>
>   <dd>Select to scan storage pools for installation ISO images available
>   on the system.</dd>
>   </dlentry><dlentry>
> +<dt>Local Image File</dt>
> +<dd>Select to specify a path to the local image file.</dd>
> +</dlentry><dlentry>
>   <dt>Remote ISO image</dt>
>   <dd>Select to specify a remote location for an installation ISO image.</dd>
>   </dlentry></dl>
>   </csbody>
>   </cshelp>
>   <cshelp id="kimhaddloct">
> -<title>Add template - local ISO image</title>
> -<shortdesc>Add a template from a local ISO image.</shortdesc>
> +<title>Add template - ISO image</title>
> +<shortdesc>Add a template from a ISO image.</shortdesc>
>   <csbody>
> -<p>The ISO images available on the system are displayed.</p>
> +<p>The ISO images available on the system ore remotely are displayed.</p>

Just a typo here 'ore' but I can fix is before applying.

>   <dl><dlentry>
>   <dt>OS</dt>
>   <dd>Name of the operating system or distribution.</dd>
> @@ -105,7 +108,7 @@ specify a path to the ISO image.</li>
>   ISO images.</li>
>   </ul></li>
>   </ul>
> -</csbody>
> +</csbody><?Pub Caret -2?>
>   </cshelp>
>   </cshelp>
> -<?Pub *0000004089?>
> +<?Pub *0000004194?>




More information about the Kimchi-devel mailing list