[Kimchi-devel] [PATCH 0/2] Template disk format fixes

dhbarboza82 at gmail.com dhbarboza82 at gmail.com
Wed Jul 15 21:35:39 UTC 2015


From: Daniel Henrique Barboza <dhbarboza82 at gmail.com>

Kimchi does not obey the value set by the template, always
creating a disk of format 'qcow2' even if the user set another
format.

This patchset fixes this issue by:

- always set the disk format with the value the user set, unless there
is a storagepool restrition

- getting the default disk format type in template.conf. This value 
is optional and will be used in the case the user does not provide
any other value.

- if there is no user choice and no default set in template.conf, the
default disk format will be 'qcow2'.


See the code and unit tests for more info.

Daniel Henrique Barboza (2):
  Getting default disk format from template.conf
  New unit tests to check disk creation behavior

 src/kimchi/vmtemplate.py |  19 +++++++--
 tests/test_model.py      | 106 ++++++++++++++++++++++++++++++++++++++++++++++-
 2 files changed, 120 insertions(+), 5 deletions(-)

-- 
2.4.3




More information about the Kimchi-devel mailing list