[Kimchi-devel] [PATCH 0/4 v3][Memory HotPlug] Implements backend of memory device hotplug

[Daniel Henrique Barboza]

A few errors in the unit tests that this patch set caused:

Failed in both Intel (F21) and Power:


FAIL: test_edit_vm (test_rest.HttpsRestTests)
FAIL: test_edit_vm (test_rest.RestTests)


Failed in Power only, works in Intel:

FAIL: test_to_xml (test_vmtemplate.VMTemplateTests


Thanks,


Daniel

On 06/04/2015 04:38 PM, Rodrigo Trujillo wrote:
> v3:
> * Implemented sugestions from Aline's review:
>     - removed memory devices API;
>     - Improved vm update function to check if vm is running and
>       update memory accordingly;
>     - moved xml function to xmlutils;
>     - removed libvirt checking from attachDeviceFlags test function
>     - moved maxMemory to osinfo.py
> * Fixed some issues with CPU update
>
>
> V2
> - Fix erros in tests and add a test to slots number
> - Fix other minor issues with Libvirt < 1.2.14
>
>
> V1
> This patchset implements the backend part of memory hotplug functionality,
> including:
> - new feature test to check if libvirt supports memory devices
> - changes the way that memory is assigned or updated in the guest xml:
> 	* memory is now set in a basic NUMA node
> - includes maxMemory element in the XML:
> 	* which is equal the total memory of the host
> 	* sets memory device slots. The total number of slots are equal the
>            maxMemory minus the memory assigned (1 slot == 1 GB )
> - creates a new VM device, the memory device:
> 	* by default, a memory device will have 1GB
> 	* user can add the memory device with machine running or offline
> - memory devices are selected according to its position in the xml (the slot)
>    0, 1, 2, etc
>
> URL:
> 	- http://localhost:8010/vms/<VM>/memdevices
> 	- http://localhost:8010/vms/<VM>/memdevices/<MEM-DEV>
>
>
>
> Rodrigo Trujillo (4):
>    [Memory HotPlug] Feature test to check support to memory devices
>    [Memory HotPlug] Add maxMemory into templates
>    [Memory HotPlug] Add maxMemory and numa configuration to guest xml
>    [Memory HotPlug] Fix test and adds slot test
>
>   src/kimchi/i18n.py               |   7 ++
>   src/kimchi/model/config.py       |   3 +
>   src/kimchi/model/featuretests.py |  43 +++++++++++
>   src/kimchi/model/vms.py          | 149 +++++++++++++++++++++++++++++++++++----
>   src/kimchi/osinfo.py             |   4 ++
>   src/kimchi/vmtemplate.py         |  28 +++++---
>   src/kimchi/xmlutils/cpu.py       |  60 ++++++++++++++++
>   tests/test_model.py              |   2 +-
>   tests/test_rest.py               |   4 +-
>   tests/test_vmtemplate.py         |   5 +-
>   10 files changed, 279 insertions(+), 26 deletions(-)
>   create mode 100644 src/kimchi/xmlutils/cpu.py
>