[Kimchi-devel] [PATCH V2 0/5] View/Edit guest MAC address

[Crístian Deives]

Reviewed-by: Crístian Deives <cristiandeives at gmail.com>

On 13-05-2015 15:39, Jose Ricardo Ziviani wrote:
> V2:
>   - Updated API.json to reflect only mac address as required parameter.
>   - Removed input text filters.
>   - Updated error message.
>
> This patchset implements a new feature in Kimchi, it allows users to view and/or edit a guest MAC address.
>
> I have a fork of kimchi in my github, so if you prefer to use their diff tool (syntax highlight) you can check this link out:
> https://github.com/kimchi-project/kimchi/compare/master...jrziviani:guest_mac
>
> Jose Ricardo Ziviani (5):
>    Display MAC Address in guest interface tab
>    Fix URI format of guest interfaces
>    Implement backend code to edit MAC address of a guest
>    Implement frontend code to edit MAC address of a guest
>    Update test cases to reflect MAC address update changes
>
>   src/kimchi/API.json                 | 13 ++------
>   src/kimchi/control/vm/ifaces.py     |  2 +-
>   src/kimchi/i18n.py                  |  4 ++-
>   src/kimchi/model/vmifaces.py        | 60 ++++++++++++++++++++++++++-----------
>   tests/test_model.py                 | 17 +++++++++--
>   tests/test_rest.py                  | 12 ++++----
>   ui/css/theme-default/guest-edit.css |  2 +-
>   ui/js/src/kimchi.guest_edit_main.js | 44 ++++++++++++++++++---------
>   ui/pages/guest-edit.html.tmpl       |  8 ++++-
>   9 files changed, 109 insertions(+), 53 deletions(-)
>