[Kimchi-devel] [PATCH] Fix SLES version checking in interfaces.py

[Crístian Viana]

Reviewed-by: Crístian Deives <cristiandeives at gmail.com>

On Wed, May 20, 2015 at 12:49 PM Paulo Ricardo Paz Vital <pvital at gmail.com>
wrote:

>
> Reviewed-by: Paulo Vital <pvital at gmail.com>
>
> > On 20 May 2015, at 12:18, Rodrigo Trujillo <
> rodrigo.trujillo at linux.vnet.ibm.com> wrote:
> >
> > This patch fixes a bug in interfaces.py. A parenthesis is missing, so
> > when the user tries to create a SLES ppc64 guest, kimchi is going to
> > raise the error:
> > AttributeError: 'unicode' object has no attribute 'version'
> >
> > Signed-off-by: Rodrigo Trujillo <rodrigo.trujillo at linux.vnet.ibm.com>
> > ---
> > src/kimchi/xmlutils/interface.py | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/kimchi/xmlutils/interface.py
> b/src/kimchi/xmlutils/interface.py
> > index f725821..82ac505 100644
> > --- a/src/kimchi/xmlutils/interface.py
> > +++ b/src/kimchi/xmlutils/interface.py
> > @@ -56,7 +56,7 @@ def get_iface_xml(params, arch=None, os_distro=None,
> os_version=None):
> >        ((os_distro == 'ubuntu' and
> >          LooseVersion(os_version) >= LooseVersion('14.04')) or
> >         (os_distro == 'sles' and
> > -         LooseVersion(os_version >= LooseVersion('12')))):
> > +         LooseVersion(os_version) >= LooseVersion('12'))):
> >         interface.append(E.driver(name='qemu'))
> >
> >     return ET.tostring(interface, encoding='utf-8', pretty_print=True)
> > --
> > 2.1.0
> >
> > _______________________________________________
> > Kimchi-devel mailing list
> > Kimchi-devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20150520/66414b9c/attachment.html>