[Kimchi-devel] [PATCH] Does not list non-bootable ISOs on template creation

[Aline Manera]

The tests are failing with this patch:

======================================================================
ERROR: test_iso_scan_shallow (test_rest.HttpsRestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "test_rest.py", line 922, in test_iso_scan_shallow
     '/storagepools/kimchi_isos/storagevolumes/').read())[0]
IndexError: list index out of range

======================================================================
ERROR: test_iso_scan_shallow (test_rest.RestTests)
----------------------------------------------------------------------
Traceback (most recent call last):
   File "test_rest.py", line 922, in test_iso_scan_shallow
     '/storagepools/kimchi_isos/storagevolumes/').read())[0]
IndexError: list index out of range

----------------------------------------------------------------------
Ran 137 tests in 444.199s

FAILED (errors=2, skipped=2)

Please, run "make check" and "make check-local" to confirm the patch 
does not break anything.

On 21/05/2015 11:29, Ramon Medeiros wrote:
> Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
> ---
>   src/kimchi/model/storagevolumes.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/kimchi/model/storagevolumes.py b/src/kimchi/model/storagevolumes.py
> index dc807e4..2081fd1 100644
> --- a/src/kimchi/model/storagevolumes.py
> +++ b/src/kimchi/model/storagevolumes.py
> @@ -530,7 +530,7 @@ class IsoVolumesModel(object):
>               for volume in volumes:
>                   res = self.storagevolume.lookup(pool_name,
>                                                   volume.decode("utf-8"))
> -                if res['format'] == 'iso':
> +                if res['format'] == 'iso' and res["bootable"] == True:
>                       res['name'] = '%s' % volume
>                       iso_volumes.append(res)
>           return iso_volumes