[Kimchi-devel] [PATCH 2/2] Issue #737 : fix to remove multiple calls for resource lookup

Aline Manera alinefm at linux.vnet.ibm.com
Tue Oct 13 12:43:35 UTC 2015


HI Archana,

Is this output from wok or Kimchi tests?

To make sure your patch does not break anything else, run "make check" 
prior and before your changes and make sure any new failure is added.

Regards,
Aline Manera

On 12/10/2015 10:36, Archana Singh wrote:
> "make check" is failing for me for the latest-code I pulled from 
> git(without any changes).  Could you please let me know if something 
> need to be done which is system specific?
>
>
>
>
> On 10/9/2015 4:30 AM, Aline Manera wrote:
>>
>> There are tests failing with this patch.
>> Please, run "make check" on wok and kimchi to make sure your patch 
>> does not break anything.
>>
>> On 05/10/2015 12:50, archus at linux.vnet.ibm.com wrote:
>>> From: Archana Singh <archus at linux.vnet.ibm.com>
>>>
>>> Signed-off-by: Archana Singh <archus at linux.vnet.ibm.com>
>>> ---
>>>   src/wok/control/base.py | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/wok/control/base.py b/src/wok/control/base.py
>>> index 5c5c95f..912ed16 100644
>>> --- a/src/wok/control/base.py
>>> +++ b/src/wok/control/base.py
>>> @@ -163,7 +163,7 @@ class Resource(object):
>>>                                    self.role_key, self.admin_methods)
>>>
>>>           try:
>>> -            self.lookup()
>>> +            self.info = {}
>>>               if not self.is_authorized():
>>>                   raise UnauthorizedError('WOKAPI0009E')
>>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151013/b913a90f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: image/png
Size: 182368 bytes
Desc: not available
URL: <http://lists.ovirt.org/pipermail/kimchi-devel/attachments/20151013/b913a90f/attachment.png>


More information about the Kimchi-devel mailing list