[Kimchi-devel] [PATCH] [WOK] Remove libvirtd service as requirement to wokd.

[Aline Manera]

Hi Paulo,

I understand and agree we need to remove libvirtd service as wokd 
dependency.
But in other hand, we need to create a mechanism to allow the plugins 
specify their own services dependencies - through a configuration file 
or settings.
For example, Kimchi depends on libvirtd service. But other plugins may 
have different dependencies.

Probably, investigate if systemd and upstart already have support to sub 
services or something like that.
Or in worst case, create a script to read the plugins configuration file 
and make sure the services are up and running when needed on wokd 
starting up.

Regards,
Aline Manera

On 16/09/2015 16:44, pvital at linux.vnet.ibm.com wrote:
> From: Paulo Vital <pvital at linux.vnet.ibm.com>
>
> libvirtd is listed as requirement service to start before wokd service. However,
> wokd is a common web framework that supports many plugins which not necessarily
> need libvirt to be running.
>
> Signed-off-by: Paulo Vital <pvital at linux.vnet.ibm.com>
> ---
>   contrib/wokd.service.fedora | 2 --
>   contrib/wokd.sysvinit       | 2 +-
>   2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/contrib/wokd.service.fedora b/contrib/wokd.service.fedora
> index 17414d3..a3af29b 100644
> --- a/contrib/wokd.service.fedora
> +++ b/contrib/wokd.service.fedora
> @@ -1,7 +1,5 @@
>   [Unit]
>   Description=Wok - Webserver Originated from Kimchi
> -Requires=libvirtd.service
> -After=libvirtd.service
>
>   [Service]
>   Type=simple
> diff --git a/contrib/wokd.sysvinit b/contrib/wokd.sysvinit
> index 10680ee..e2c34c7 100644
> --- a/contrib/wokd.sysvinit
> +++ b/contrib/wokd.sysvinit
> @@ -22,7 +22,7 @@
>   #
>   ### BEGIN INIT INFO
>   # Provides: wokd
> -# Required-Start: libvirtd
> +# Required-Start:
>   # Required-Stop:
>   # Default-Start: 3 5
>   # Default-Stop: 0 1 2 6
> --
> 2.4.3