[Kimchi-devel] [PATCH] [Kimchi] Issue #924: Before deleting a storagepool, kimchi should check if any template is using that

[Paulo Ricardo Paz Vital]

Reviewed-by: Paulo Vital <pvital at linux.vnet.ibm.com>

On Apr 07 04:27PM, Jose Ricardo Ziviani wrote:
> ---
>  model/storagepools.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/model/storagepools.py b/model/storagepools.py
> index cf3ed21..4a0d34c 100644
> --- a/model/storagepools.py
> +++ b/model/storagepools.py
> @@ -33,6 +33,7 @@ from wok.plugins.kimchi.model.host import DeviceModel
>  from wok.plugins.kimchi.model.libvirtstoragepool import StoragePoolDef
>  from wok.plugins.kimchi.osinfo import defaults as tmpl_defaults
>  from wok.plugins.kimchi.scan import Scanner
> +from wok.plugins.kimchi.utils import pool_name_from_uri
> 
> 
>  ISO_POOL_NAME = u'kimchi_isos'
> @@ -437,7 +438,7 @@ class StoragePoolModel(object):
>                  t_info = session.get('template', tmpl)
>                  for disk in t_info['disks']:
>                      t_pool = disk['pool']['name']
> -                    if t_pool == pool_name:
> +                    if pool_name_from_uri(t_pool) == pool_name:
>                          return True
>              return False
> 
> -- 
> 1.9.1
> 
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
> 

-- 
Paulo Ricardo Paz Vital
Linux Technology Center, IBM Systems
http://www.ibm.com/linux/ltc/