[Kimchi-devel] [RFC] [Kimchi] Add support to edit virtual networks

[Aline Manera]

On 04/15/2016 03:55 PM, Lucio Correia wrote:
> On 15-04-2016 15:37, Samuel Guimarães wrote:
>>
>>
>> 2016-04-15 15:20 GMT-03:00 Samuel Guimarães <sguimaraes943 at gmail.com
>> <mailto:sguimaraes943 at gmail.com>>:
>>
>>
>>
>>     2016-04-05 18:02 GMT-03:00 Lucio Correia
>>     <luciojhc at linux.vnet.ibm.com <mailto:luciojhc at linux.vnet.ibm.com>>:
>>
>>         Edit virtual network feature
>>
>>         Pre-requisite:
>>         - Virtual network is stopped
>>         - Virtual network "default" is not editable
>>
>>         *** BACKEND ***
>>
>>         ### Resource: Network
>>
>>         **URI:** /plugins/kimchi/networks/*:name*
>>
>>         **Methods:**
>>
>>         * **UPDATE**: Update a Network
>>              * name: The name of the Network
>>              * subnet: Network segment in slash-separated format with ip
>>         address and prefix
>>              * dhcp: DHCP services on the virtual network is enabled.
>>                  * start: start boundary of a pool of addresses to be
>>         provided to DHCP clients.
>>                  * end: end boundary of a pool of addresses to be
>>         provided to DHCP clients.
>>              * interfaces: An array of bridge network interfaces that
>>         belongs to this network
>>                            All traffic on this network will be bridged
>>         through the first
>>                            interface. The interface is a bridge or
>>         ethernet/bonding device.
>>              * vlan ID
>>
>>         Not all attributes are required for all networks types.
>>
>>
>>         *** FRONTEND ***
>>
>>         * Add new option Edit to Actions menu under
>>         Virtualization/Network tab, enabled only for stopped networks
>>         * When clicked, this option will open a new window for editing
>>         that virtual network, with the following fields. Based on
>>         network type, some of below fields may be disabled:
>>
>>         Type: just a label describing the network type, not changeable.
>>         Name: all types of virtual network can be renamed
>>         Interfaces: attach/detach interfaces (enabled for VEPA) or
>>         change interface (for macvtap, bridged)
>>         Subnet/DHCP range: two IP fields: start, end (enabled for NAT,
>>         isolated)
>>         VLAN id: integer field (enabled for bridged networks)
>>
>>
>>     I'm ok with this. The modal window should look almost the same as
>>     the "Add Network" window, except for the Network type that will be a
>>     "readonly" input.
>>
>>
>> BTW, should we add a mask for the Subnet and DHCP IP fields? I think I
>> saw somewhere someone asking for a mask for IP addresses but I wasn't
>> able to find anything that supports both ipv4 and ipv6 strings at the
>> same time.
>
> Hi Samuel, this is not correct, sorry for the confusion.
>
> It should be only one field. Call it "Address space", same term used 
> when listing the networks.
>
> That field will accept something like 127.0.0.0/24
>
> I'm not sure about IPV6 support in Kimchi. Aline?
>

It would be good to have a mask for the fields to restrict user inputs. 
Only IPv4 is supported in the current implementation.

> Regards,
>
>
>>
>>
>>
>>         --
>>         Lucio Correia
>>         Software Engineer
>>         IBM LTC Brazil
>>
>>         _______________________________________________
>>         Kimchi-devel mailing list
>>         Kimchi-devel at ovirt.org <mailto:Kimchi-devel at ovirt.org>
>>         http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>>
>>
>>
>
>