[Kimchi-devel] [PATCH] [Kimchi 2/2] s390x based architecture changes.

[Archana Singh]

Hi Daniel,

Sure, I will try similar to ppc boot detection  and will be working on 
figure out how can we detect it on s390x, and will be sending followup 
patches for same. Till then we can have bootable as yes on s390x machine 
as without which template creation cannot be proceeded further on s390x.

I will send V2 patch solving all make check-local issues.

Thanks,

Archana

On 08/09/2016 06:38 PM, Daniel Henrique Barboza wrote:
> Archana, have you tried to test the PPC boot detection with
> the s390x ISOs? The PPC boot detection is based on finding a
> file named /ppc/bootinfo.txt. Perhaps something similar
> can be made for s390x?
>
> This is a topic that I have interest in investigating (I wrote an article
> about this PPC boot detection code I've wrote in Kimchi) so let me
> know if you need any assistance with that.
>
>
> Daniel
>
> On 08/09/2016 05:53 AM, archus at linux.vnet.ibm.com wrote:
>> From: Archana Singh <archus at linux.vnet.ibm.com>
>>
>> On s390x machine current implemented code cannot be used for
>> checking iso is bootable or not.
>> Make changes to set it always True for s390x machine, and can be
>> implemenated in future.
>>
>> Signed-off-by: Archana Singh <archus at linux.vnet.ibm.com>
>> ---
>>   isoinfo.py | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/isoinfo.py b/isoinfo.py
>> index d7ca044..d8bec2d 100644
>> --- a/isoinfo.py
>> +++ b/isoinfo.py
>> @@ -395,6 +395,14 @@ 
>> lang=en#!/wiki/W51a7ffcf4dfd_4b40_9d82_446ebc23c550/page/PowerLinux\
>>           # If reached this point the file wasn't found = not bootable
>>           self.bootable = False
>>   +    def _scan_s390x(self):
>> +       """
>> +        s390x firmware does not use the conventional El Torito boot
>> +        specification. This method will be used to check s390x image
>> +        is bootable or not. Till then this will set bootable True.
>> +        """
>> +       self.bootable= True
>> +
>>       def _scan_primary_vol(self, data):
>>           """
>>           Scan one sector for a Primary Volume Descriptor and extract 
>> the
>> @@ -445,6 +453,8 @@ 
>> lang=en#!/wiki/W51a7ffcf4dfd_4b40_9d82_446ebc23c550/page/PowerLinux\
>>           self._scan_primary_vol(data)
>>           if platform.machine().startswith('ppc'):
>>               self._scan_ppc()
>> +        elif platform.machine().startswith('s390x'):
>> +            self._scan_s390x()
>>           else:
>>               self._scan_el_torito(data)
>
> _______________________________________________
> Kimchi-devel mailing list
> Kimchi-devel at ovirt.org
> http://lists.ovirt.org/mailman/listinfo/kimchi-devel
>