[Kimchi-devel] [PATCH][Kimchi 0/2] Do not delete pool and network in use by templates or guests

[Daniel Henrique Barboza]

What you did in test_rest.py was to modify the existing test because you 
changed
the logic. Which is fine.

However, you changed a test that was verifying the removal of a storage 
pool to
a test that is verifying that a pool in use by a guest isn't being 
removed. The test
is now just verifying your new condition.  You need to add the removal 
test back in
test_rest.py by removing all storage in the VM and then asserting that 
the removal
was succeeded. I suggest you do it just after your modified assertion.


Also:


contrib/check_i18n.py ./i18n.py
Checking for invalid i18n string...
Checking for invalid i18n string successfully
/bin/pep8 --version
1.6.2
/bin/pep8 --filename '*.py,*.py.in' 
--exclude="*config.py,*i18n.py,*tests/test_config.py" .
./model/storagepools.py:476:66: W291 trailing whitespace
Makefile:1062: recipe for target 'check-local' failed
make: *** [check-local] Error 1
[danielhb at arthas kimchi]$





On 08/17/2016 02:30 PM, Ramon Medeiros wrote:
> Ramon Medeiros (2):
>    Do not remove storagepools linked to guests
>    Update tests
>
>   i18n.py               |  1 +
>   model/storagepools.py | 21 +++++++++++++++++++++
>   tests/test_rest.py    |  4 +++-
>   3 files changed, 25 insertions(+), 1 deletion(-)
>