[Kimchi-devel] [PATCH][Kimchi] Fix when calling error message in storagepool

Daniel Henrique Barboza dhbarboza82 at gmail.com
Thu Aug 18 19:55:57 UTC 2016



On 08/18/2016 04:39 PM, Ramon Medeiros wrote:
> Error message was waiting a string with index "pool", instead of "name"
>
> Signed-off-by: Ramon Medeiros <ramonn at linux.vnet.ibm.com>
> ---
>   model/storagevolumes.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/model/storagevolumes.py b/model/storagevolumes.py
> index 91e1c6b..c55217c 100644
> --- a/model/storagevolumes.py
> +++ b/model/storagevolumes.py
> @@ -284,7 +284,7 @@ class StorageVolumeModel(object):
>       def get_storagevolume(poolname, name, conn):
>           pool = StoragePoolModel.get_storagepool(poolname, conn)
>           if not pool.isActive():
> -            raise InvalidOperation("KCHVOL0006E", {'name': pool})
> +            raise InvalidOperation("KCHVOL0006E", {'pool': pool.name()})

The method receives 'poolname' as parameter. You can use it instead of
calling pool.name().

>           try:
>               return pool.storageVolLookupByName(name.encode("utf-8"))
>           except libvirt.libvirtError as e:




More information about the Kimchi-devel mailing list