[Kimchi-devel] [PATCH V1] [Kimchi] For s390x architecture, serial type is not validated in vm xml as as not supported on s390x.

archus at linux.vnet.ibm.com archus at linux.vnet.ibm.com
Tue Aug 30 12:43:06 UTC 2016


From: Archana Singh <archus at linux.vnet.ibm.com>

This changes ensure that in vm xml serial type is not validated for s390x
as not supported in s390x architecture and only console type is validated
in _vm_check_serial.

Signed-off-by: Archana Singh <archus at linux.vnet.ibm.com>
---
 model/vms.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/model/vms.py b/model/vms.py
index 7f607f5..d3d2cb1 100644
--- a/model/vms.py
+++ b/model/vms.py
@@ -1486,7 +1486,8 @@ class VMModel(object):
         xml = dom.XMLDesc(libvirt.VIR_DOMAIN_XML_SECURE)
 
         expr = "/domain/devices/serial/@type"
-        if not xpath_get_text(xml, expr):
+        # on s390x serial is not supported
+        if platform.machine() != 's390x' and not xpath_get_text(xml, expr):
             return False
 
         expr = "/domain/devices/console/@type"
-- 
2.7.4




More information about the Kimchi-devel mailing list