[Kimchi-devel] [PATCH] [Wok 3/5] Log user requests

[Aline Manera]

On 02/26/2016 10:47 AM, Lucio Correia wrote:
> On 26-02-2016 10:41, Aline Manera wrote:
>>> diff --git a/src/wokd.in b/src/wokd.in
>>> index 7255d3c..c91f07a 100644
>>> --- a/src/wokd.in
>>> +++ b/src/wokd.in
>>> @@ -36,6 +36,7 @@ if not config.paths.installed:
>>>
>>>   ACCESS_LOG = "wok-access.log"
>>>   ERROR_LOG = "wok-error.log"
>>> +REQ_LOG = "wok-req.log"
>>>
>>>
>>>   def main(options):
>>> @@ -76,6 +77,9 @@ def main(options):
>>>       parser.add_option('--error-log',
>>>                         default=os.path.join(logDir, ERROR_LOG),
>>>                         help="Error log file")
>>
>>> +    parser.add_option('--req-log',
>>> +                      default=os.path.join(logDir, REQ_LOG),
>>> +                      help="User Request log file")
>>
>> What is the proposal of this option? I don't think we can let the user
>> change the log file directory as the cherrpy configuration depends on 
>> that.
>
> There are two places where files are save.
>
> This one is for saving the JSON log, and it's saved in the same 
> directory of the other cherrypy logs, wok-access and wok-error. The 
> option was added to keep the same behaviour of these logs.
>
> The temporary logs, for the download functionality, are saved in 
> another directory, which cannot be changed.
>

I don't think it is needed
We can have only one place to save the log files. Otherwise, it is hard 
to understand (from an user point of view) the difference between the 2 logs